Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pause non-flowing subscription #73

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

mohwahab
Copy link
Collaborator

@mohwahab mohwahab commented May 30, 2024

Expected Retry Behaviour

  1. A retry should be triggered if the consumer replies with a retriable error and the Max Retry configuration is > 0.
  2. No further retries should be triggered once retries are exhausted (retry_count == Max Retry). i.e. Receiving new event(s) should not trigger a retry.
  3. No retry should be triggered if the consumer replies with a non-retriable error.
  4. A manual restart resets the retry count, a retry should be triggered (applies to any non-flowing subscription).
  5. An automatic refresh (every 10 mins) resets the retry count, a retry should be triggered (applies to any non-flowing subscription).
  6. Receiving new event(s) to a non-flowing subscription should not trigger a retry.

@mohwahab mohwahab requested a review from Rotorsoft May 30, 2024 11:03
Copy link
Owner

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Rotorsoft Rotorsoft merged commit fdba51a into master May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants