Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27: Added Codable support #28

Merged
merged 1 commit into from
Oct 18, 2021
Merged

#27: Added Codable support #28

merged 1 commit into from
Oct 18, 2021

Conversation

KyLeggiero
Copy link
Collaborator

  • Added Tests/SemVerTests/Testing tools.swift to encapsulate access to module internal scope
    • Removed all usages of @testable
    • Added SemVerTestClass to let all test classes inherit shared behavior like setting isTesting to true

- Added `Tests/SemVerTests/Testing tools.swift` to encapsulate access to module `internal` scope
    - Removed all usages of `@testable`
    - Added `SemVerTestClass` to let all test classes inherit shared behavior like setting `isTesting` to `true`
@KyLeggiero KyLeggiero self-assigned this Oct 18, 2021
@KyLeggiero KyLeggiero added the enhancement New feature or request label Oct 18, 2021
Copy link
Collaborator Author

@KyLeggiero KyLeggiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KyLeggiero KyLeggiero merged commit 2c0d302 into develop Oct 18, 2021
@KyLeggiero KyLeggiero linked an issue Oct 18, 2021 that may be closed by this pull request
@KyLeggiero KyLeggiero mentioned this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conform to Codable
1 participant