Super basic form app/'context' trail #92

luketlancaster · 2019-10-10T15:48:13Z

Add the Clubhouse Story ID: [ch21093]

not sure about...most of this. So rip 'er up and lemme know what you think

src/js/apps/forms/form/form_app.js

luketlancaster · 2019-10-10T15:48:55Z

src/js/views/forms/form/form.scss

+  &:hover {
+    color: color(blue);
+  }
+}


just cripped all of this from the patient scss

luketlancaster · 2019-10-10T15:49:17Z

src/js/views/forms/form/form_views.js

+  },
+  templateContext() {
+    return {
+      src: `${ window.location.origin }/formapp/${ this.model.id }`,


? stabs in the dark here

luketlancaster · 2019-10-10T15:49:51Z

test/integration/forms/form.js

-      .find('[data-patients-region] .app-nav__link')
-      .last()
-      .click({ force: true });
+      .wait(2000);


waiting doesn't feel great, but not sure the best way to make sure the form is loaded? Should it be stubbed out with form data? Or somesuch?

I don't think we should test the contents of the iframe, just the src for now. but https://github.com/RoundingWell/RWell/blob/develop/cypress/support/commands.js#L42 when we do.

I don't think we need the wait to check the src?

codecov · 2019-10-10T15:51:20Z

Codecov Report

Merging #92 into develop will decrease coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #92      +/-   ##
===========================================
- Coverage    97.63%   97.57%   -0.06%     
===========================================
  Files           79       82       +3     
  Lines         1436     1442       +6     
===========================================
+ Hits          1402     1407       +5     
- Misses          34       35       +1

Impacted Files	Coverage Δ
src/js/apps/globals/app-frame_app.js	`100% <ø> (ø)`	⬆️
src/js/apps/forms/form/form_app.js	`100% <100%> (ø)`
src/js/views/forms/form/form_views.js	`100% <100%> (ø)`
src/js/apps/forms/forms-main_app.js	`100% <100%> (ø)`
src/js/base/entity-service.js	`95.83% <0%> (-4.17%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 564f6c8...e4e1af1. Read the comment docs.

cypress · 2019-10-10T15:52:11Z

Test summary

47 • 0 • 0 • 0

Run details


Project	RoundingWell Care Ops Frontend
Status	Passed
Commit	`e4e1af1`
Started	Oct 11, 2019 1:14 PM
Ended	Oct 11, 2019 1:15 PM
Duration	01:06 💡
OS	Linux Debian - 9.6
Browser	Electron 61

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

paulfalgout · 2019-10-10T16:24:23Z

src/js/apps/forms/form/form_app.js

+import { LayoutView } from 'js/views/forms/form/form_views';
+
+export default App.extend({
+  currentAppOptions() {


this is the default. you can remove this

paulfalgout · 2019-10-10T16:31:55Z

src/js/views/forms/form/form_views.js

+        </a>
+      </div>
+      <h1>{{ name }}</h1>
+      <iframe src="{{ src }}" class="form__frame"></iframe>


does src="/formapp/{{ id }}" work?

form loads, so yeah I think so!

paulfalgout · 2019-10-10T16:32:39Z

test/integration/forms/form.js

@@ -1,21 +1,30 @@
 context('Patient Form', function() {
  specify('routing to form', function() {
+    cy


is this visit needed? If so that may be a problem

nope, sure isn't!

paulfalgout · 2019-10-10T16:35:55Z

test/integration/forms/form.js

-      .find('[data-patients-region] .app-nav__link')
-      .last()
-      .click({ force: true });
+      .wait(2000);


I don't think we should test the contents of the iframe, just the src for now. but https://github.com/RoundingWell/RWell/blob/develop/cypress/support/commands.js#L42 when we do.

paulfalgout · 2019-10-10T19:14:42Z

test/integration/forms/form.js

-      .get('[data-nav-region]')
-      .should('be.visible');
+      .get('iframe')
+      .should($iframe => {


its('src').should('contain' I think

gave that a shot, but was getting a 'could not find property' of src

hmm maybe its doesn't work on attributes.. how about should('have.attr'?

paulfalgout · 2019-10-10T19:14:52Z

test/integration/forms/form.js

-      .find('[data-patients-region] .app-nav__link')
-      .last()
-      .click({ force: true });
+      .wait(2000);


I don't think we need the wait to check the src?

paulfalgout · 2019-10-11T05:51:13Z

src/js/views/forms/form/form_views.js

+        </a>
+      </div>
+      <h1>{{ name }}</h1>
+      <iframe height="100px" src="/formapp/{{ id }}" class="form__frame"></iframe>


I'm just now noticing the height here. all styling should be in the class.

ah crap. I put this in to test its to see if it would wok on props like this and forgot to remove

paulfalgout · 2019-10-11T06:02:39Z

test/integration/forms/form.js

-      .get('[data-nav-region]')
-      .should('be.visible');
+      .get('iframe')
+      .should($iframe => {


hmm maybe its doesn't work on attributes.. how about should('have.attr'?

luketlancaster requested a review from paulfalgout October 10, 2019 15:48

luketlancaster commented Oct 10, 2019

View reviewed changes

src/js/apps/forms/form/form_app.js Outdated Show resolved Hide resolved

luketlancaster commented Oct 10, 2019

View reviewed changes

paulfalgout requested changes Oct 10, 2019

View reviewed changes

luketlancaster force-pushed the feature/ch21093-form-layout-context-trail branch from 509b06c to c678cac Compare October 10, 2019 18:31

luketlancaster requested a review from paulfalgout October 10, 2019 18:32

paulfalgout requested changes Oct 10, 2019

View reviewed changes

luketlancaster force-pushed the feature/ch21093-form-layout-context-trail branch from c678cac to 148bbaf Compare October 11, 2019 01:39

luketlancaster requested a review from paulfalgout October 11, 2019 01:40

paulfalgout requested changes Oct 11, 2019

View reviewed changes

Super basic form app/'context' trail

e4e1af1

luketlancaster force-pushed the feature/ch21093-form-layout-context-trail branch from 148bbaf to e4e1af1 Compare October 11, 2019 13:12

luketlancaster requested a review from paulfalgout October 11, 2019 13:12

paulfalgout approved these changes Oct 11, 2019

View reviewed changes

paulfalgout merged commit 1472ef7 into develop Oct 11, 2019

paulfalgout deleted the feature/ch21093-form-layout-context-trail branch October 11, 2019 16:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Super basic form app/'context' trail #92

Super basic form app/'context' trail #92

luketlancaster commented Oct 10, 2019

luketlancaster Oct 10, 2019

luketlancaster Oct 10, 2019

luketlancaster Oct 10, 2019

paulfalgout Oct 10, 2019

paulfalgout Oct 10, 2019

codecov bot commented Oct 10, 2019 •

edited

Loading

cypress bot commented Oct 10, 2019 •

edited

Loading

paulfalgout Oct 10, 2019

paulfalgout Oct 10, 2019

luketlancaster Oct 10, 2019

paulfalgout Oct 10, 2019

luketlancaster Oct 10, 2019

paulfalgout Oct 10, 2019

paulfalgout Oct 10, 2019

luketlancaster Oct 11, 2019

paulfalgout Oct 11, 2019

paulfalgout Oct 10, 2019

paulfalgout Oct 11, 2019

luketlancaster Oct 11, 2019

paulfalgout Oct 11, 2019

Super basic form app/'context' trail #92

Super basic form app/'context' trail #92

Conversation

luketlancaster commented Oct 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 10, 2019 • edited Loading

Codecov Report

cypress bot commented Oct 10, 2019 • edited Loading

Test summary

Run details

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 10, 2019 •

edited

Loading

cypress bot commented Oct 10, 2019 •

edited

Loading