Add support for WSL hosts file #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Only issue with this is that it can't actually write to Window's HOSTS file unless you change the permissions on it. I'm told there may be something like |
|
Interesting, let me make some test to ensure it does not affect other cases. Great contribution 👍 |
|
Just adjusted this so that it properly writes a Windows-style line ending in the Windows HOSTS file (before it was working, but would behave weirdly if you opened up HOSTS in Windows) |
RoverWire
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks if a hosts file exists at
/mnt/c/Windows/System32/drivers/etc/hosts, and if so, attempts to add or remove the virtual host specified. This makes the script more compatible with Microsoft's Windows Subsystem on Linux.