Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load recipe-altering recipes before world load #17

Closed
Neubulae opened this issue Mar 19, 2021 · 3 comments
Closed

Load recipe-altering recipes before world load #17

Neubulae opened this issue Mar 19, 2021 · 3 comments
Labels
wontfix This will not be worked on

Comments

@Neubulae
Copy link

Loading Datapacks -> Loading World -> Loading Carpet config -> Reload

It's a bit redundant on server startups, tho that sounds like a hard issue

@RubixDev
Copy link
Owner

I would be able to move the recipe files in the correct location before Minecraft reloads its resources for the first time, but Carpet Mod only parses the config file after that, so at that point I don't know which recipes should be included and which don't. I could parse the important rules earlier myself to circumvent this, though that would be quite a lot of work and I'm not sure if it's even worth it at that point.

@Neubulae
Copy link
Author

I would be able to move the recipe files in the correct location before Minecraft reloads its resources for the first time, but Carpet Mod only parses the config file after that, so at that point I don't know which recipes should be included and which don't. I could parse the important rules earlier myself to circumvent this, though that would be quite a lot of work and I'm not sure if it's even worth it at that point.

I guess you could then do something as a quality-of-life improvement, like:
First time loading the config -> Dump the recipes to the correct location
then if the conf file is not changed and the recipes aren't altered, keep it as is, otherwise do it again?

@RubixDev
Copy link
Owner

Hi, sorry for not answering for so long. As you might have noticed I moved away to other projects.
Regarding your request I decided it is not worth it trying to get it to work, just for a cleaner and slightly faster start. I might have another look sometime later though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants