Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Plan | Player Analytics #35

Closed
aisukuma opened this issue Jan 19, 2022 · 3 comments
Closed

Incompatible with Plan | Player Analytics #35

aisukuma opened this issue Jan 19, 2022 · 3 comments
Assignees
Labels
incompatibilty Incompatible with another mod

Comments

@aisukuma
Copy link

aisukuma commented Jan 19, 2022

No server crash, but it removes the /plan command from Plan | Player Analytics.

Here is a gist of the latest.log if you need it.

@RubixDev
Copy link
Owner

before I can investigate further, plan-player-analytics/Plan#2969 will have to be addressed

@RubixDev
Copy link
Owner

Okay so after some tinkering I found out that the issue seems to be caused by the data reload during the first data load which is required for the custom crafting recipes. It was always ugly to have this reload there and already caused a problem with another mod, but so far I never found a way around it (see #41 and #17).
I will likely have another go and see where I get.

@RubixDev
Copy link
Owner

Well it works now, but I had to Inject into Carpet's SettingsManager class. Instead of loading all Minecraft resources twice during launch, instead the Carpet config is now read twice, but that is still much less demanding.

I will release v1.4.1 with this fix shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibilty Incompatible with another mod
Projects
None yet
Development

No branches or pull requests

2 participants