Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): nbt,predicates,gamemode allow =! operator #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JosefLitos
Copy link
Contributor

@JosefLitos JosefLitos commented Oct 31, 2023

hi, I just ran into this, it's a very basic fix, but valuable nevertheless.

I also deleted one line because none of it's groups are being used, (looked with vim's * keybind)

@JosefLitos JosefLitos changed the title fix(selector): nbt allows =! operator fix(filter): nbt,predicates,gamemode allow =! operator Oct 31, 2023
@JosefLitos
Copy link
Contributor Author

JosefLitos commented Nov 1, 2023

I also implemented highlighting for objectives in the scores filter. I thought it would be nice if the parentheses matched the color of the NBT parentheses, so I changed the link there from mcOp to mcNBTBracket. I don't know what's better though, so no problem changing it back.

I also don't understand vimscript, nor the way the highlighting is being done here, so I just added the code, but I shall improve its structure if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant