Alternative configure docker #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [apipie-rails](https://github.com/Apipie/apipie-rails) from 0.5.9 to 0.5.10. - [Release notes](https://github.com/Apipie/apipie-rails/releases) - [Changelog](https://github.com/Apipie/apipie-rails/blob/master/CHANGELOG.md) - [Commits](Apipie/apipie-rails@v0.5.9...v0.5.10) Signed-off-by: dependabot[bot] <support@dependabot.com>
* Add tests for viewing the projects API links * Add slack channel link to show page Added link for the projects slack channel. This is needed to so that individuals can easily find a projects slack channel. Fix AgileVentures#770 * Add slack channel name to tests Updated the background job to include the slack channel for the hello project * Update slack link assertion Updated the assertion to check for the slack channel name instead of the Project title since project title will not always be the same as the slack channel name. * Run migration to add slack channel name Added slack_channel_name to projects table. Storing the slack channel name for each project will allow us to create links that direct users to the correct slack channel for the project. * Update link to use the slack channel name * Fix grammar in cucumber test * Add CRUD tests for slack channel name * Update CRUD views to include slack channel name * Add test for when slack channel does not exist Added to test to check that the view renders revelant information when a slack channel does not exist. * Update view to render correct slack status The view was updated to render "not linked to Slack" when the project doesn't have a slack channel name associated to it. * Update test to check the views else route The github test is now failing for this, but it's working locally and in production which means there is a bug somewhere in the tests. * Remove building source repository When a github link is not present a source repository should not be built as this was causing the project to have a github source repository even though the link is nil. * Update tests now that source repo is not built There are three tests failing due to the source repository not being built for every project regardless if there is a valid github link. Source repo's should only exist when there are github links associated to a project. These three tests were trying to add github links to a project that didn't previously had a github link, hence the button needed to be clicked before the value could be filled in. * Replace hard link with param name * Permit slack channel name params
acts_as_follower is no longer maintained. Forked Gem to fix deprecation warning spamming the output of our tests.
Bumps [ice_cube](https://github.com/seejohnrun/ice_cube) from 0.16.2 to 0.16.3. - [Release notes](https://github.com/seejohnrun/ice_cube/releases) - [Changelog](https://github.com/seejohnrun/ice_cube/blob/master/CHANGELOG.md) - [Commits](ice-cube-ruby/ice_cube@v0.16.2...v0.16.3) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [public_activity](https://github.com/pokonski/public_activity) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/pokonski/public_activity/releases) - [Changelog](https://github.com/chaps-io/public_activity/blob/1-6-stable/CHANGELOG.md) - [Commits](https://github.com/pokonski/public_activity/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 3.13.0 to 3.13.1. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/master/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [public_activity](https://github.com/pokonski/public_activity) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/pokonski/public_activity/releases) - [Changelog](https://github.com/chaps-io/public_activity/blob/1-6-stable/CHANGELOG.md) - [Commits](https://github.com/pokonski/public_activity/commits/v1.6.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
To not track catch exceptions in development environment
To ensure latest npm version To install dependencies necessary for the project
npm install erroring out, was outdated
Cleaner to run inside container Not needed as Node is being installed and run within Ruby container
To work for local developers as well as docker users
Remove explicit copy javascript dependencies as they are copied in a postinstall by running npm install Remove debugging list contents of vendor/assets/javascripts
Bumps [apipie-rails](https://github.com/Apipie/apipie-rails) from 0.5.9 to 0.5.10. - [Release notes](https://github.com/Apipie/apipie-rails/releases) - [Changelog](https://github.com/Apipie/apipie-rails/blob/master/CHANGELOG.md) - [Commits](Apipie/apipie-rails@v0.5.9...v0.5.10) Signed-off-by: dependabot[bot] <support@dependabot.com>
* Add tests for viewing the projects API links * Add slack channel link to show page Added link for the projects slack channel. This is needed to so that individuals can easily find a projects slack channel. Fix AgileVentures#770 * Add slack channel name to tests Updated the background job to include the slack channel for the hello project * Update slack link assertion Updated the assertion to check for the slack channel name instead of the Project title since project title will not always be the same as the slack channel name. * Run migration to add slack channel name Added slack_channel_name to projects table. Storing the slack channel name for each project will allow us to create links that direct users to the correct slack channel for the project. * Update link to use the slack channel name * Fix grammar in cucumber test * Add CRUD tests for slack channel name * Update CRUD views to include slack channel name * Add test for when slack channel does not exist Added to test to check that the view renders revelant information when a slack channel does not exist. * Update view to render correct slack status The view was updated to render "not linked to Slack" when the project doesn't have a slack channel name associated to it. * Update test to check the views else route The github test is now failing for this, but it's working locally and in production which means there is a bug somewhere in the tests. * Remove building source repository When a github link is not present a source repository should not be built as this was causing the project to have a github source repository even though the link is nil. * Update tests now that source repo is not built There are three tests failing due to the source repository not being built for every project regardless if there is a valid github link. Source repo's should only exist when there are github links associated to a project. These three tests were trying to add github links to a project that didn't previously had a github link, hence the button needed to be clicked before the value could be filled in. * Replace hard link with param name * Permit slack channel name params
acts_as_follower is no longer maintained. Forked Gem to fix deprecation warning spamming the output of our tests.
mattwr18
force-pushed
the
alternative_configure_docker
branch
from
b560cf0
to
b2c6ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.