Fix RuboCop lint offenses #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ end | |||
|
|
|||
| APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__) | |||
|
|
|||
| load 'rails/tasks/engine.rake' if File.exists?(APP_RAKEFILE) | |||
| load 'rails/tasks/engine.rake' if File.exist?(APP_RAKEFILE) | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
File.exists? is deprecated - it generates a warning when Ruby is run in verbose mode from Ruby 2.1.0 onwards.
|
That looks good to go. Thanks, @agrimm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix most of the offenses reported by RuboCop when run with the
--lintoption.This was done so that when this gem is used while warnings are turned on (
RUBYOPT="-w"), this gem produces fewer warnings.The gem will still produce warnings about uninitialized instance variables being retrieved by monetizable.rb