Panda Assignment submission. #20

codeblahblah · 2014-02-03T20:26:22Z

Created a panda.rb file in the Models directory.

jwo · 2014-02-04T15:16:20Z

models/panda.rb

@@ -0,0 +1,13 @@
+class Automobile
+  attr_accessor :color, :make, :model, :year
+  def self.wheels?


a method that ends in "?" should return a true/false

jwo · 2014-02-04T15:19:25Z

Good first step at a Panda submission -- let me know if you have any questions on it, and be sure to ping me "@jwo" when you push new code for this pull request.

codeblahblah · 2014-02-04T16:21:41Z

Gotcha.
Will re-attempt it.
How does pinging on Github work?

On 4 February 2014 17:19, Jesse Wolgamott notifications@github.com wrote:

Good first step at a Panda submission -- let me know if you have any
questions on it, and be sure to ping me "@jwo https://github.com/jwo"
when you push new code for this pull request.

Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-34069375
.

"When you are tired of being yourself then you can be ordinary." - dudu

jwo · 2014-02-04T16:25:03Z

You should type “@jwo"

On Tuesday, February 4, 2014 at 10:21 AM, drammopo wrote:

Gotcha.
Will re-attempt it.
How does pinging on Github work?

On 4 February 2014 17:19, Jesse Wolgamott <notifications@github.com (mailto:notifications@github.com)> wrote:

Good first step at a Panda submission -- let me know if you have any
questions on it, and be sure to ping me "@jwo https://github.com/jwo"
when you push new code for this pull request.

Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-34069375
.

"When you are tired of being yourself then you can be ordinary." - dudu

—
Reply to this email directly or view it on GitHub (#20 (comment)).

codeblahblah · 2014-02-04T16:59:05Z

Corrections made.

jwo · 2014-02-04T17:02:08Z

Looks good. The only thing missing is:

I should be able to pass in a hash of color, make, model, and year to the class to update its variables

So, I should be able to:

auto = Automobile.new(x,y,z)
auto.update(a,b,c)

codeblahblah · 2014-02-04T17:29:38Z

Added update method to the class.

jwo · 2014-02-04T17:44:09Z

models/tiger.rb

+p auto
+auto.update(color: 'Blue', year: 2012)
+puts auto.color
+puts auto.year


what does purs auto.model output? Is it what you expect?

codeblahblah · 2014-02-04T17:58:00Z

puts auto.model returns nil.
Not what I expected.
Changed code to @model ||= new_args[:model]
Alternatively could have used @model = new_args[:model] unless @model.
Which is 'better' syntax?

jwo · 2014-02-04T18:01:16Z

@model ||= new_args[:model] is dependent on the state of @model
@model = new_args[:model] unless @model will never override @model

What you want to do is overwrite, if the arg is there, otherwise you leave it. This is the most common form of that expression

@model = new_args[:model] if new_args[:model]

You could also use fetch with a default to achieve a cleaner, but possibly harder to understand look:

@model = new_args.fetch(:model, @model)

codeblahblah · 2014-02-04T18:23:13Z

For now I'll use:

@model = new_args[:model] if new_args[:model]

The correction has been made.

jwo · 2014-02-04T18:24:03Z

models/tiger.rb

+
+  def update(new_args)
+    @color = new_args[:color] if new_args[:color]
+    @make ||= new_args[:make] if new_args[:make]


why use "||=" ?

codeblahblah · 2014-02-04T18:28:49Z

Well spotted.
Fixed.
Thanks.

jwo · 2014-02-04T18:30:03Z

Awesome 🎉 !

…all vehicles made.

codeblahblah · 2014-02-06T17:39:17Z

@jwo Automobiles are not counted when created? All other types are. Why is that?

jwo · 2014-02-06T17:48:52Z

Oh, should have caught that. Call "super" in your subclass, and it'll call the initialize in your superclass. So when auto is initialized, if you call super, it will call initialize of Vehicle as well.

On Thu, Feb 6, 2014 at 11:39 AM, drammopo notifications@github.com
wrote:

@jwo Automobiles are not counted when created? All other types are. Why is that?

Reply to this email directly or view it on GitHub:
#20 (comment)

codeblahblah · 2014-02-06T17:55:46Z

I had that in my original code and but got:
eagle.rb:3:in `initialize': wrong number of arguments (1 for 0) (ArgumentError)

See snippet below

  def initialize(args)
    @color = args[:color]
    @make = args[:make]
    @model = args[:model]
    @year = args[:year]
    super
  end

jwo · 2014-02-06T18:04:20Z

Ahh try

super()

That's tell ruby to only call it with 0 arguments.

On Thu, Feb 6, 2014 at 11:55 AM, drammopo notifications@github.com
wrote:

I had that in my original code and but got:
eagle.rb:3:in `initialize': wrong number of arguments (1 for 0) (ArgumentError)
See snippet below
  def initialize(args)
    @color = args[:color]
    @make = args[:make]
    @model = args[:model]
    @year = args[:year]
    super
  end
Reply to this email directly or view it on GitHub:
#20 (comment)

…ments.

codeblahblah · 2014-02-06T18:07:29Z

Working now.
Thanks.

jwo · 2014-02-07T19:21:59Z

It would seem that the following are not needed

 Vehicle.register(self)
 Automobile.build_car(args)

And you don't need both a build and a build_car method, right?

jwo · 2014-02-07T19:23:35Z

To clarify, this is what I'm after:

class Automobile
 def initialize(args)
    @color = args[:color]
    @make = args[:make]
    @model = args[:model]
    @year = args[:year]
    Vehicle.register(self)
    Automobile.build_car(args)
    super()
  end

  def self.build(args)
    auto = Automobile.build(args)
    @@vehicles << auto
    auto
  end

end

describe Automobile do
  it "records the auto when I build it" do
    auto = Automobile.build
    expect(Automobile.all_autos).to include?(auto)
  end
end

codeblahblah · 2014-02-07T19:37:34Z

@jwo Please expand on the Autobile.all_autos method.
Is it similar to the Vehicle.count in the sense that each Auto created will be sent to a @@atuos variable?
In which case you are checking that Array via the include?(auto) statement

Also can you call self.build on itself as per your example above?

  def self.build(args)
    auto = Automobile.build(args)
    @@vehicles << auto
    auto
  end

jwo · 2014-02-07T19:39:41Z

Yes it's similar.

Also can you call self.build on itself as per your example above?

Yes, why do you think you couldn't?

On Fri, Feb 7, 2014 at 1:37 PM, drammopo notifications@github.com wrote:

@jwo Please expand on the Autobile.all_autos method.
Is it similar to the Vehicle.count in the sense that each Auto created will be sent to a @@atuos variable?
In which case you are checking that Array via the include?(auto) statement
Also can you call self.build on itself as per your example above?
  def self.build(args)
    auto = Automobile.build(args)
    @@vehicles << auto
    auto
  end
Reply to this email directly or view it on GitHub:
#20 (comment)

codeblahblah · 2014-02-07T19:51:47Z

@jwo Hmmmm. I see the error in my thinking.
As per the code below, there's no need for a #register as we do so via @@vehicles << auto
I'm still stuck on #build. Does it take the current instance and send it forward? i.e the self that was created during the Automobile.new?
In which case you cannot call Automobile.build before Automobile.new? Which kinda makes sense in the real world...

class Automobile
 def initialize(args)
    @color = args[:color]
    @make = args[:make]
    @model = args[:model]
    @year = args[:year]
    Automobile.build(args)
    super()
  end

  def self.build(args)
    auto = Automobile.build(args)
    @@vehicles << auto
    auto
  end
end

describe Automobile do
  it "records the auto when I build it" do
    auto = Automobile.build
    expect(Automobile.all_autos).to include?(auto)
  end
end

jwo · 2014-02-07T20:20:35Z

Here is what I want in this discussion. You don't register when you call Automobile.new

class Automobile
 def initialize(args)
    @color = args[:color]
    @make = args[:make]
    @model = args[:model]
    @year = args[:year]
    super()
  end

You register if someone calls Automobile.build

That makes Automobile.build your API endpoint, and leaves Automobile.new for your internal stuff.

In the same way, in Rails, you can call User.create if you'd like to, which would "register" (save to the database) the user being created.

codeblahblah · 2014-02-07T20:48:53Z

@jwo
Gotcha.
The difference comes in that you can call User.count immediately after User.create because a save to the database has occurred.
In our case you'd have to:
Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007) then Automobile.build because there's no middle-man for storage.

The latest code is up.
Please have a look at automobile_spec.rb as it fails on account of it expecting arguments whereas you examples above do not.

jwo · 2014-02-07T21:32:18Z

here's what I'd love to see

Automobile.count
=> 0
Automobile.build(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)
Automobile.count
=> 1

codeblahblah · 2014-02-07T21:41:17Z

@jwo
Aside from the obvious, how is Automobile.build(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007) different from Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)

jwo · 2014-02-07T21:44:08Z

Well, this is an exercise in showing the difference between class methods and initialization methods.

In a production system, you don't want an initializer to have side effects. You should be able to create objects without effects. Then, you can call different methods to persist or otherwise affect them.

On Fri, Feb 7, 2014 at 3:41 PM, drammopo notifications@github.com wrote:

@jwo

Aside from the obvious, how is Automobile.build(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007) different from Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)

Reply to this email directly or view it on GitHub:
#20 (comment)

codeblahblah · 2014-02-07T21:47:05Z

@jwo
Made this change and it works now

  def self.build(args)
    auto = Automobile.new(args)
    @@vehicles << auto
    @@auto << auto
    auto
  end

jwo · 2014-02-07T21:50:08Z

awesome!

On Fri, Feb 7, 2014 at 3:47 PM, drammopo notifications@github.com wrote:

@jwo
Made this change and it works now
  def self.build(args)
    auto = Automobile.new(args)
    @@vehicles << auto
    @@auto << auto
    auto
  end
Reply to this email directly or view it on GitHub:
#20 (comment)

codeblahblah · 2014-02-07T21:53:32Z

@jwo Used the Rails operation(s) all the time without understanding what was going on under the hood. Thanks for this!

jwo · 2014-02-07T22:13:18Z

Used the Rails operation(s) all the time without understanding what was going on under the hood. Thanks for this!

That is literally the coolest, best compliment you can give me for this course 🎉 😄

Do you approve for me to use it in a testimonial?

codeblahblah · 2014-02-07T22:18:25Z

Definitely.
Provided I can see where it's being posted first.

Midnight all ready. Gotta catch some Zzzz.
Cheers

codeblahblah · 2014-02-08T18:11:11Z

@jwo I made a pun related to cars without realising.
I've created my first test suite.
What do you think?

jwo · 2014-02-11T02:14:50Z

spec/automobile_spec.rb

+
+
+  before :each do
+    @auto = Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)


I would rather you use "let" instead of @auto.

Instead of

before :each do @auto = Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007) end

I would

let(:auto) { Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007) }

Then later,

auto.should be_an_instance_of Automobile

jwo · 2014-02-11T02:15:53Z

Test suite looks most excellent!

I think you have this down (and also the longest pull request ever :) )

codeblahblah · 2014-02-11T11:17:17Z

@jwo Awesome!
Had my first Ah-ha moment during the exercise which lead me to http://betterspecs.org/
Will make the changes as suggested.

codeblahblah · 2014-02-11T19:08:25Z

@jwo Am I testing the Vehicle#search correctly?

jwo · 2014-02-11T19:09:41Z

Can you point me to where you are testing it?

codeblahblah · 2014-02-11T19:14:44Z

@jwo /spec/vehicle_spec.rb

jwo · 2014-02-11T19:15:40Z

Going to say no, vehicle_spec looks extremely bare.

codeblahblah · 2014-02-11T19:29:35Z

@jwo Apologies.
Had a commit issue.
Please have a look now.

jwo · 2014-02-11T20:39:13Z

spec/vehicle_spec.rb

+      Automobile.build model: :toyota, color: :red, make: 'Corolla', year: 2010
+      auto = Automobile.build model: :honda, color: :blue, make: 'Civic', year: 2013
+      Automobile.build model: :mazda, color: :blue, make: 'Accord', year: 2003
+      Vehicle.search(color: "blue", model: "honda").first.should eq(auto)


This seems like a fine search. It doesn't cover all functionality though.

I might like it if it were the following, where you are more assertive about the results.

Vehicle.search(color: "blue", model: "honda").should eq([auto])

codeblahblah added 3 commits February 3, 2014 22:22

Panda Assignment submission.

7617310

Corrections to Panda Assignment submission.

66d4a23

Tiger Assignment submission.

86755ba

jwo reviewed Feb 4, 2014
View reviewed changes

Panda and Tiger assignment corrections.

4344aac

Added update feature to Automobile class.

93e0222

jwo reviewed Feb 4, 2014
View reviewed changes

Stopped update method from resetting instance variables if set.

4fa755a

Feature: Allow overwrite on update.

31b8b38

jwo reviewed Feb 4, 2014
View reviewed changes

Feature: Fixed typos.

c5bf5c3

Eagle level: Create a class variable (@@) in the Vehicle that tracks …

3a2f800

…all vehicles made.

Eagle level: Corrected Automobile super method call to take zero argu…

73bb8b6

…ments.

Cleaned up registration process and add test case ideas.

4b8b0bb

Feature: Added .build . First Automobile test case now passes.

e476509

Feature: Added Automobile and Motorcycle test specs.

4e247f2

jwo reviewed Feb 11, 2014
View reviewed changes

Switched to RSpec's let(:sym) {} syntax and added more tests.

c7e1d6d

Latest Vehicle test specfications including #search test

0ef2e55

jwo reviewed Feb 11, 2014
View reviewed changes



		before :each do
		@auto = Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)

Panda Assignment submission. #20

Are you sure you want to change the base?

Panda Assignment submission. #20

Conversation

codeblahblah commented Feb 3, 2014

jwo Feb 4, 2014

Choose a reason for hiding this comment

jwo commented Feb 4, 2014

codeblahblah commented Feb 4, 2014

jwo commented Feb 4, 2014

codeblahblah commented Feb 4, 2014

jwo commented Feb 4, 2014

codeblahblah commented Feb 4, 2014

jwo Feb 4, 2014

Choose a reason for hiding this comment

codeblahblah commented Feb 4, 2014

jwo commented Feb 4, 2014

codeblahblah commented Feb 4, 2014

jwo Feb 4, 2014

Choose a reason for hiding this comment

codeblahblah commented Feb 4, 2014

jwo commented Feb 4, 2014

codeblahblah commented Feb 6, 2014

jwo commented Feb 6, 2014

@jwo Automobiles are not counted when created? All other types are. Why is that?

codeblahblah commented Feb 6, 2014

jwo commented Feb 6, 2014

codeblahblah commented Feb 6, 2014

jwo commented Feb 7, 2014

jwo commented Feb 7, 2014

codeblahblah commented Feb 7, 2014

jwo commented Feb 7, 2014

codeblahblah commented Feb 7, 2014

jwo commented Feb 7, 2014

codeblahblah commented Feb 7, 2014

jwo commented Feb 7, 2014

codeblahblah commented Feb 7, 2014

jwo commented Feb 7, 2014

Aside from the obvious, how is Automobile.build(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007) different from Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)

codeblahblah commented Feb 7, 2014

jwo commented Feb 7, 2014

codeblahblah commented Feb 7, 2014

jwo commented Feb 7, 2014

codeblahblah commented Feb 7, 2014

codeblahblah commented Feb 8, 2014

jwo Feb 11, 2014

Choose a reason for hiding this comment

jwo commented Feb 11, 2014

codeblahblah commented Feb 11, 2014

codeblahblah commented Feb 11, 2014

jwo commented Feb 11, 2014

codeblahblah commented Feb 11, 2014

jwo commented Feb 11, 2014

codeblahblah commented Feb 11, 2014

jwo Feb 11, 2014

Choose a reason for hiding this comment

Aside from the obvious, how is `Automobile.build(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)` different from `Automobile.new(model: 'Mustang', color: 'Red', make: 'Ford', year: 2007)`