Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ajax api request to get market hash. #25

Merged
merged 5 commits into from
Jun 30, 2024
Merged

Use ajax api request to get market hash. #25

merged 5 commits into from
Jun 30, 2024

Conversation

Rudokhvist
Copy link
Owner

@Rudokhvist Rudokhvist commented Mar 5, 2024

Changes

  • Uses /ajaxgetbadgeinfo/ API endpoint for getting own badges - this allows to get market hash of cards.
  • cards are matched by card number instead of card name - in case /ajaxgetbadgeinfo/ and badge pages return different names.
  • Use market hash to fill trade offers - should solve issues like Users who use steam language other than English may sometimes get error "Items missing" #22
  • Added custom user-agent header to requests to ASFB - for statistics tracking.

Needs extensive testing before merging. If anyone wants to help testing - installation link is here

@Bertaz
Copy link

Bertaz commented Apr 29, 2024

Tested and it seems to work better than master. It finds an additional trade for Ultimate General: Civil War.
It's also slightly faster, ajax version took 10m 31s 143ms, while master took 10m 37s 913ms. This was with only 1 tradable badge. I imagine the difference will be higher with more badges/bots.
Quickly checked the verbose output and it seems to do everything correctly:

Log output

very long files, gzipped
2 tradable badges, found 6 matches
previous log with no available matches

The warning from #26 is not present in this version.
I checked the verbose logs for any personal information. It seems to only lists cards, my timezone and bots' steam profile ids, not even listing my profile id. Please tell me if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants