Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CLI errors when running Artisan commands #2

Merged
merged 1 commit into from Mar 3, 2018
Merged

Prevent CLI errors when running Artisan commands #2

merged 1 commit into from Mar 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2018

The package often causes CLI errors when executing Artisan commands and composer dump-autoload, the reason for this is that it attempts to load the Service Provider which references the current route, which if you're on CLI is null.

By wrapping it around the Laravel optional() helper this issue is adverted, rather than failing with an exception the Service provider simply silently passes null into the Active instance.

@Rukhsar Rukhsar merged commit 3a6d6b7 into Rukhsar:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant