Issue33 math func #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wscsprint3r
approved these changes
Jun 16, 2018
| * Decimal Formatting Solution | ||
| * https://stackoverflow.com/questions/153724/how-to-round-a-number-to-n-decimal-places-in-java | ||
| */ | ||
| public static Double getRoundedResult(Double value, Integer precision, RoundingMode rm) { |
There was a problem hiding this comment.
This needs to be moved to some utility class, it doesn't make sense to have it in the Iterator as a static method.
It would be good if you could find a pre-existing solution since rounding of doubles is not an uncommon problem.
This may or may not help you:
https://commons.apache.org/proper/commons-math/javadocs/api-3.3/org/apache/commons/math3/util/Precision.html
|
This is awesome work, Can. I have added my minor comments inline. |
ghislainfourny
requested changes
Jun 18, 2018
| @@ -0,0 +1,7 @@ | |||
| (:JIQS: ShouldRun; Output="( 0.0, 2.0, 2.0, 3567.81, 0.0, 35600.0)" :) | |||
| roundhalftoeven(0.5), | |||
There was a problem hiding this comment.
the name should be round-half-to-even
| @@ -0,0 +1,6 @@ | |||
| (:JIQS: ShouldRun; Output="( 0.0, -0.0, 1000.0)" :) | |||
| sqrt(0.0e0), | |||
There was a problem hiding this comment.
It would be great to add a test for sqrt of a negative number (double-checking which error should be returned in the specification)
ghislainfourny
approved these changes
Jul 9, 2018
Closed
AndreaRinaldi1
pushed a commit
to AndreaRinaldi1/rumble
that referenced
this pull request
Oct 12, 2019
Issue33 math func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All mathematical functions have been implemented.
When implementing "round" and "roundhalftoeven" I defined a rounding function in the "RoundFunctionIterator" which is used by both iterators. If you have suggestions for a better practise or location to define the function please let me know.
With the recently added functions the functions folder is getting quite crowded. Moving them to a "Numeric" folder or multiple folders such as "trigonometric", "exponential" and so on can be beneficial for organization.