Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiplicativeOp empty sequence support and Issue 24 fix #66

Merged
merged 3 commits into from
Sep 24, 2018

Conversation

CanBerker
Copy link
Collaborator

Empty sequence support and lazy evaluation has been implemented for Multiplicative operation.

Additionally bug fix introduced in #47 has been implemented with the corrections that were suggested by Stefan applied. Previous PR (#47) is closed

Copy link
Member

@ghislainfourny ghislainfourny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Assuming Stefan approves the details too)

@CanBerker CanBerker changed the base branch from OperationalItr to CommaExpressionItr September 23, 2018 19:34
@CanBerker CanBerker changed the base branch from CommaExpressionItr to OperationalItr September 23, 2018 19:34
@CanBerker
Copy link
Collaborator Author

Test cases for multiplicative operations added

@CanBerker CanBerker changed the base branch from OperationalItr to master September 24, 2018 19:00
@CanBerker CanBerker merged commit 7de43dd into master Sep 24, 2018
@CanBerker CanBerker deleted the MultiplicativeItr branch September 24, 2018 19:03
AndreaRinaldi1 pushed a commit to AndreaRinaldi1/rumble that referenced this pull request Oct 12, 2019
MultiplicativeOp empty sequence support  and Issue 24 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants