Bugfix: iptables timing #1384
Merged
Bugfix: iptables timing #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experienced this on one of my nodes (and seen it mentioned in discord by one person)
This has only affected my ubuntu 20.04 node, (I only have one) so don't know if it's based on the versions in use on this system or something else.
We were running the iptables rules and ufw rules at the same time - and ufw uses iptables under the hood so getting a lock on xtables.
This pull just runs these function synchronously, so they don't compete. Also moved the iptable deny rules before ufw (makes sense to deny host traffic first then clear ufw)
Tested on my Ubuntu 20.04 node - fixed the issue.