Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new -frust-dump-hir-experimental to use the new HIR::Dump interface #1333

Closed
4 tasks
CohenArthur opened this issue Jun 24, 2022 · 0 comments · Fixed by #1335
Closed
4 tasks

Add new -frust-dump-hir-experimental to use the new HIR::Dump interface #1333

CohenArthur opened this issue Jun 24, 2022 · 0 comments · Fixed by #1335
Assignees
@ndrwnaguib

Comments

@CohenArthur
Copy link
Member

  • Add new kHIRExperimentalDumpFile (gccrs.hir-experimental.dump for example)
  • Add new enum value CompileOptions::HIR_EXPERIMENTAL_DUMP
  • Handle "hir-experimental" as a dump option in the Session::enable_dump function
  • Add a call into the HIR::Dump interface if the option is enabled, right after the call to dump_hir in the Session::parse_file function
ndrwnaguib added a commit that referenced this issue Jun 24, 2022
@ndrwnaguib
cli: add "hir-pretty" as a "dump" option
0b02755 
Instead of mixing the ongoing project of pretty dumping the HIR with the current
implementation, this commit adds a new option "-frust-dump-hir-pretty" which
calls the hir pretty dump visitor class. Closes #1333
@ndrwnaguib ndrwnaguib mentioned this issue Jun 24, 2022
Merged
bors bot added a commit that referenced this issue Jun 24, 2022
@bors @ndrwnaguib
Merge #1335
9911861 
1335: cli: add "hir-pretty" as a "dump" option r=CohenArthur a=ndrwnaguib

Fixes #1333 

Instead of mixing the ongoing project of pretty dumping the HIR with the current
implementation, this commit adds a new option "-frust-dump-hir-pretty" which
calls the hir pretty dump visitor class. Closes #1333



Co-authored-by: andrewnaguib <24280372+ndrwnaguib@users.noreply.github.com>
@bors bors bot closed this as completed in 557b8d9 Jun 24, 2022
@bors bors bot closed this as completed in #1335 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndrwnaguib ndrwnaguib

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: add "hir-pretty" as a "dump" option Rust-GCC/gccrs
2 participants
@ndrwnaguib @CohenArthur