Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements and fixes #1402

Merged
merged 1 commit into from
Jul 29, 2022
Merged

CI Improvements and fixes #1402

merged 1 commit into from
Jul 29, 2022

Conversation

liushuyu
Copy link
Contributor

@liushuyu liushuyu commented Jul 20, 2022

@liushuyu liushuyu changed the title CI Improvements CI Improvements and fixes Jul 20, 2022
@liushuyu
Copy link
Contributor Author

The explanation for why this fixes Remark:

Node.js 12.x (LTS: Erbium) is an ancient version that does not support newer JavaScript/ECMAScript syntaxes. Upgrading to Node.js 16.x (LTS: Gallium) fixes the issue because it is a relatively new version that supports up to ECMAScript 2021.

Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for taking the time :)

.github/workflows/bootstrap.yml Outdated Show resolved Hide resolved
@CohenArthur CohenArthur added the CI label Jul 20, 2022
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that these two commits be separated over two PR's. I am not sure about the 6gb ulimit change that's all dependant on the github CI infrastructure which we cant control. But the remark automation looks good.

... update Node.js to the latest LTS branch
@liushuyu
Copy link
Contributor Author

I am not sure about the 6gb ulimit change that's all dependant on the github CI infrastructure which we cant control.

That's true, however, GitHub uses Azure's facility, and Microsoft explicitly stated the VM SKU for GitHub Actions is Standard_DS2_v2. And here is the documentation: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources.

@philberty
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 29, 2022

Build succeeded:

@bors bors bot merged commit 7f1685d into Rust-GCC:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remark CI complains about JavaScript syntax
3 participants