-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Improvements and fixes #1402
Conversation
liushuyu
commented
Jul 20, 2022
•
edited
Loading
edited
- CI: fix Remark check (fix Remark CI complains about JavaScript syntax #1340)
The explanation for why this fixes Remark: Node.js 12.x (LTS: Erbium) is an ancient version that does not support newer JavaScript/ECMAScript syntaxes. Upgrading to Node.js 16.x (LTS: Gallium) fixes the issue because it is a relatively new version that supports up to ECMAScript 2021. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for taking the time :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that these two commits be separated over two PR's. I am not sure about the 6gb ulimit change that's all dependant on the github CI infrastructure which we cant control. But the remark automation looks good.
... update Node.js to the latest LTS branch
That's true, however, GitHub uses Azure's facility, and Microsoft explicitly stated the VM SKU for GitHub Actions is |
bors r+ |
Build succeeded: |