-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ErrorCode[E0433]: Use of Undeclared Crate, Module, or Type #2301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! The video is a nice touch :D but I think it's time consuming, so don't worry about it for the next time :) thank you!
a428fd7
to
8b51f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work
Can you confirm if we have test cases for this error in our test suite? |
@philberty After running mahad/gccrs/gcc/testsuite/rust/compile/cfg1.rs:29:5: error: Cannot find path 'test' in this scope [E0433]
compiler exited with status 1
mahad/gccrs/gcc/testsuite/rust/compile/lookup_err1.rs:6:5: error: Cannot find path 'nested' in this scope [E0433]
compiler exited with status 1
mahad/gccrs/gcc/testsuite/rust/compile/self-path2.rs:13:12: error: failed to resolve: 'self' in paths can only be used in start position [E0433]
mahad/gccrs/gcc/testsuite/rust/compile/self-path2.rs:20:17: error: failed to resolve: 'self' in paths can only be used in start position [E0433]
compiler exited with status 1 |
@MahadMuhammad do you know how to fix your commit message format and code formatting? |
@philberty said:
I am having some formatting issues :( |
6b96708
to
e0c3592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had misunderstood part of your PR - please remove the TODO
comments which are being fixed by this very PR haha. Then I'll merge the PR :)
3801ee5
to
c5108d9
Compare
gcc/rust/ChangeLog: * resolve/rust-ast-resolve-path.cc (ResolvePath::resolve_path): called rust_error_at * resolve/rust-ast-resolve-type.cc (ResolveRelativeTypePath::go): called rust_error_at Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Added rustc E0433 error code. Failed to resolve: Use of Undeclared Crate, Module, or Type
E0433.mp4
gcc/rust/ChangeLog:
Signed-off-by: Muhammad Mahad mahadtxt@gmail.com