[E0380] Use of auto trait with method or associated item #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
approved these changes
Aug 10, 2023
|
@MahadMuhammad is this ready to go? It looks good |
MahadMuhammad
commented
Aug 10, 2023
CohenArthur
reviewed
Aug 16, 2023
gcc/rust/parse/rust-parse-impl.h
Outdated
Comment on lines
4925
to
4926
| rust_error_at (locus, ErrorCode::E0380, | ||
| "auto traits cannot have methods or associated items"); |
There was a problem hiding this comment.
yes, this does change the behavior of the code. add_error adds the created error to an internal table in the parser, which can choose to emit them later on or not. so we need to keep using add_error instead of rust_error_at
gcc/rust/ChangeLog: * parse/rust-parse-impl.h (Parser::parse_trait): added errorcode & updated error message. gcc/testsuite/ChangeLog: * rust/compile/auto_trait_invalid.rs: Updated comment. Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of auto trait with a method or an associated item -
E0380add_errortorust_error_atRunning testcase:
gcc/testsuite/rust/compile/auto_trait_invalid.rsgcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: