Initial autoderef support for method calls #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is compiler magic for method calls the self parameter can be of
several forms:
- specified type (self: Type)
- immutable Self (self)
- mutable Self (mut self)
- immutable reference (&self)
- mutable reference (&mut self)
This updates our HIR lowering to actually lower this correctly and apply
the apropriate Self type to the TyTy::FnDef. The code used to just default
to plain Self ignoring any modifiers.
Rust also allows something called the autoderef cycle to coerce the
receiver to the correct type for the function such as:
```rust
struct Foo(i32);
impl Foo {
fn bar(&self) { }
}
fn main() {
let a = Foo(123);
a.bar();
}
```
In this example the method call is expected to apply an implict reference
to variable 'a' such that the method call becomes:
```
Foo::bar(&a);
```
The algorithm is detailed here:
https://doc.rust-lang.org/nightly/nomicon/dot-operator.html
1. Try to match Self
2. Apply an immutable Reference and Try again
3. Apply an mutable Reference and Try again
4. Can we dereference ? [deref and go back to 1] else [quit]
This is not 100% complete since we do not yet support operator overloading
so we wil require an update to support the Deref operator overload for
more complex types.
Fixes: #241
philberty
moved this from In progress
to Review in progress
in Data Structures 3 - Traits
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit message contains more detail but this reference is good:
https://doc.rust-lang.org/nightly/nomicon/dot-operator.html
This is not 100% complete since we do not yet support operator overloading
so we will require an update to support the Deref operator overload for
more complex types.
Fixes: #241