Add test coverage for cmp_default_heuristics #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -436,6 +436,7 @@ struct StreamInner { | |||
| // Minimum number of samples to put in the buffer. | |||
| period_len: usize, | |||
|
|
|||
| #[allow(dead_code)] | |||
| // Whether or not the hardware supports pausing the stream. | |||
| can_pause: bool, | |||
There was a problem hiding this comment.
Could you possibly add a // TODO: We need an API to expose this. See #197, #284.
|
Done! Thanks. |
|
Ahhhh #401 just landed today - it looks like this might need to be updated to account for it? |
Good shout. I'll take a look later. |
|
Should be passing again now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This patch adds some basic test coverage for the above function.
It also includes a tiny change adding an
#[allow(dead_code)]to kill a compilation warning in the ALSA module.