Support dynamic linking #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to dynamic loading.
wmedrano
force-pushed
the
dynamic-loading
branch
from
da5c904
to
0893646
Compare
|
While I'm glad this is coming back, I still think it's not a great idea to maintain a bespoke code generator just for this one crate. My offer remains open to revert back to dlib and reimplement everything that's been merged since then. |
wmedrano
force-pushed
the
dynamic-loading
branch
from
fe1672b
to
6fa6ad4
Compare
|
I'll pass on the offer. dlib fails if a single function is missing which is annoying at times. Also, a nit, I was not a fan of having to use the macro for function calls. |
robbert-vdh
reviewed
Nov 3, 2022
| mod functions { | ||
| include!(concat!(env!("OUT_DIR"), "/functions.rs")); | ||
| } | ||
|
|
||
| pub use consts::*; | ||
| pub use functions::*; | ||
| pub use functions::dynamic_linking; | ||
| pub use functions::dynamic_loading; |
There was a problem hiding this comment.
Shouldn't this be gated behind the feature? I think you now also need to have libjack available at compile time even when using the dynamic loading feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to dynamic loading.