k256: enable endomorphism optimizations by default; remove non-endomorphism code #211
Labels
k256
secp256k1 crate
Comments
tarcieri
added a commit
that referenced
this issue
Sep 28, 2020
The reason this wasn't enabled-by-default before was due to a lingering US patent. However, as noted on #211, that patent just expired 🎉 The `bitcoin-core/secp256k1` library is also pursuing a full switch to endomorphisms: bitcoin-core/secp256k1#826 For now this commit just switches on the feature by default, but in the future we can eventually rip out the non-endomorphism code and remove the feature entirely.
tarcieri
added a commit
that referenced
this issue
Sep 28, 2020
The reason this wasn't enabled-by-default before was due to a lingering US patent. However, as noted on #211, that patent just expired 🎉 The `bitcoin-core/secp256k1` library is also pursuing a full switch to endomorphisms: bitcoin-core/secp256k1#826 For now this commit just switches on the feature by default, but in the future we can eventually rip out the non-endomorphism code and remove the feature entirely.
|
#213 enabled the |
|
The non-endomorphism code was removed in #217. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
The last of the GLV patents in the US (US7110538B2) expired on September 25th, 2020 (and the European patents have been expired for awhile). IANAL, but from what I'm gathering endomorphisms are no longer patent-encumbered. Relevant story:
https://www.btctimes.com/news/hal-finneys-proposal-for-optimizing-bitcoin-to-be-enabled-in-bitcoin-core
bitcoin-core/secp256k1is now switching to the endomorphism implementation by default:bitcoin-core/secp256k1#826
I think it would make sense for us to do the same.
cc @fjarri @tuxxy
The text was updated successfully, but these errors were encountered: