k256: impl ecdsa::hazmat::RecoverableSignPrimitive #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
k256/recoverable-sign-primitive
branch
2 times, most recently
from
468ea8c
to
564675e
Compare
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 51.82% 51.66% -0.17%
==========================================
Files 20 20
Lines 3473 3484 +11
==========================================
Hits 1800 1800
- Misses 1673 1684 +11
Continue to review full report at Codecov.
|
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
force-pushed
the
k256/recoverable-sign-primitive
branch
from
564675e
to
51fd051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impls the
RecoverableSignPrimitivetrait introduced in RustCrypto/signatures#111 which returns the necessary information(even-or-odd) about the ECDSA signature's
Ry-coordinate to be able to compute the recovery ID without using brute force trial recovery.This implementation leaks some details the existing
ecdsacrate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.