ecdsa: add hazmat::RecoverableSignPrimitive #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trait for signature algorithm implementations that support public key recovery, with a blanket impl for SignPrimitive.
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 46.63% 45.97% -0.67%
==========================================
Files 5 6 +1
Lines 208 211 +3
==========================================
Hits 97 97
- Misses 111 114 +3
Continue to review full report at Codecov.
|
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the `RecoverableSignPrimitive` trait introduced in RustCrypto/signatures#111 which returns the necessary information (even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to compute the recovery ID without using brute force trial recovery. This implementation leaks some details the existing `ecdsa` crate APIs are trying to abstract over, but hopefully can feed into the requirements for what those APIs should actually look like.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trait for signature algorithm implementations that support public key recovery, with a blanket impl for
SignPrimitive.