p256: use a 4-bit window for scalar multiplication #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediately improves performance even on a variable base: - 35% faster on x86_64 - 37% faster on M1 - 37% faster on WebAssembly (Wasmtime) - 39% faster on WebAssembly (Wasmedge)
tarcieri
reviewed
May 25, 2022
tarcieri
reviewed
May 25, 2022
|
Thanks! Impressive performance improvement |
Co-authored-by: Tony Arcieri <bascule@gmail.com>
tarcieri
added a commit
that referenced
this pull request
May 26, 2022
Imports an MVP arithmetic implementation from: https://github.com/jedisct1/rust-p384 This includes the following: - Addition formulas from Renes-Costello-Batina 2015, adapted from @str4d's implementation in the `p256` crate - `FieldElement::{invert, sqrt}` implementations - `Scalar::{invert, sqrt}` implementations - Scalar field implementation generated using fiat-crypto - Scalar multiplication using 4-bit window ala #563 - Point compaction support
tarcieri
added a commit
that referenced
this pull request
May 26, 2022
Imports an MVP arithmetic implementation from: https://github.com/jedisct1/rust-p384 This includes the following: - Addition formulas from Renes-Costello-Batina 2015, adapted from @str4d's implementation in the `p256` crate - `FieldElement::{invert, sqrt}` implementations - `Scalar::{invert, sqrt}` implementations - Scalar field implementation generated using fiat-crypto - Scalar multiplication using 4-bit window ala #563 - Point compaction support - ECDH support using generic implementation from `elliptic-curve` - ECDSA support using generic implementation from the `ecdsa` crate
tarcieri
added a commit
that referenced
this pull request
May 26, 2022
Imports an MVP arithmetic implementation from: https://github.com/jedisct1/rust-p384 This includes the following: - Addition formulas from Renes-Costello-Batina 2015, adapted from @str4d's implementation in the `p256` crate - `FieldElement::{invert, sqrt}` implementations - `Scalar::{invert, sqrt}` implementations - Scalar field implementation generated using fiat-crypto - Scalar multiplication using 4-bit window ala #563 - Point compaction support - ECDH support using generic implementation from `elliptic-curve` - ECDSA support using generic implementation from the `ecdsa` crate
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately improves performance even on a variable base: