p384: import arithmetic from jedisct1/rust-p384 #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
May 26, 2022
brycx
suggested changes
May 26, 2022
tarcieri
force-pushed
the
p384/import-from-jedisct1-p384_rs
branch
6 times, most recently
from
60a034d
to
7ec3137
Compare
tarcieri
changed the title
|
Imported the latest changes from @jedisct1's repo, got all of the tests passing, and wrote a real commit message. Removed WIP/draft. PTAL. |
|
Sidebar: an important next step to this PR is getting the arithmetic working on 32-bit backends, including generating a 32-bit backend for the scalar field |
Imports an MVP arithmetic implementation from: https://github.com/jedisct1/rust-p384 This includes the following: - Addition formulas from Renes-Costello-Batina 2015, adapted from @str4d's implementation in the `p256` crate - `FieldElement::{invert, sqrt}` implementations - `Scalar::{invert, sqrt}` implementations - Scalar field implementation generated using fiat-crypto - Scalar multiplication using 4-bit window ala #563 - Point compaction support - ECDH support using generic implementation from `elliptic-curve` - ECDSA support using generic implementation from the `ecdsa` crate
tarcieri
force-pushed
the
p384/import-from-jedisct1-p384_rs
branch
from
7ec3137
to
4885def
Compare
|
mit-plv/fiat-crypto#1259 includes the 32-bit backend for the scalar field. |
|
See #566 for next steps |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports an MVP arithmetic implementation from:
https://github.com/jedisct1/rust-p384
This includes the following:
p256crateFieldElement::{invert, sqrt}implementationsScalar::{invert, sqrt}implementationselliptic-curvecrateecdsacrateCloses #240