[WIP] Add legacy feature with ECDSA-related traits
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECDSA signing computes the `r` component of a signature by reducing the affine x-coordinate of an ephemeral point mod n. This adds a `ReduceAffineX` trait for performing this reduction, with the goal of facilitating an ECDSA implementation which is generic over (prime order) elliptic curves. Additionally, it adds an `IsAffineYOdd` trait which is useful for computing the "recovery ID" used to recover the public key which created a signature (ala point compression).
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 81.46% 81.50% +0.03%
==========================================
Files 12 12
Lines 1392 1395 +3
==========================================
+ Hits 1134 1137 +3
Misses 258 258
Continue to review full report at Codecov.
|
tarcieri
force-pushed
the
legacy-ecdsa-functionality
branch
from
4832a05
to
49fa765
Compare
This was referenced Jul 11, 2020
Closed
|
I prefer RustCrypto/signatures#96 to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #65 which scopes the "legacy" functionality specifically to what is needed to implement ECDSA.
ECDSA signing computes the
rcomponent of a signature by reducing the affine x-coordinate of an ephemeral point mod n.This adds a
ReduceAffineXtrait for performing this reduction, with the goal of facilitating an ECDSA implementation which is generic over (prime order) elliptic curves.Additionally, it adds an
IsAffineYOddtrait which is useful for computing the "recovery ID" used to recover the public key which created a signature (ala point compression).