Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k256: Add recoverable::Signature::recover_pubkey #68

Merged
merged 1 commit into from Jul 16, 2020

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Jul 11, 2020

Conditionally implements public key recovery for recoverable::Signature when the arithmetic and sha256 Cargo features are enabled.

Recovery is only implemented for "recovery IDs" 0 and 1, as these are the only ones that occur in practice.

@cargo-dep-bot
Copy link

cargo-dep-bot bot commented Jul 11, 2020

This PR made the following dependency changes:

Added Packages (Duplicate versions in '()'):
	num-bigint 0.3.0
	num-integer 0.1.43

Removed Packages (Remaining versions in '()'):
	fiat-crypto 0.1.5

@tarcieri tarcieri mentioned this pull request Jul 11, 2020
@tarcieri tarcieri changed the title [WIP/not for merge] ECDSA public key recovery [WIP] ECDSA public key recovery Jul 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #68 into master will decrease coverage by 0.63%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   55.51%   54.87%   -0.64%     
==========================================
  Files          15       15              
  Lines        2918     2952      +34     
==========================================
  Hits         1620     1620              
- Misses       1298     1332      +34     
Impacted Files Coverage Δ
k256/src/arithmetic.rs 84.59% <ø> (ø)
k256/src/ecdsa/recoverable.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6758a...b82a98c. Read the comment docs.

Conditionally implements public key recovery for
`recoverable::Signature` when the `arithmetic` and `sha256`
Cargo features are enabled.

Recovery is only implemented for "recovery IDs" 0 and 1, as these are
the only ones that occur in practice.
@tarcieri tarcieri changed the title [WIP] ECDSA public key recovery k256: Add recoverable::Signature::recovery_pubkey Jul 16, 2020
@tarcieri tarcieri marked this pull request as ready for review July 16, 2020 19:24
@tarcieri tarcieri changed the title k256: Add recoverable::Signature::recovery_pubkey k256: Add recoverable::Signature::recover_pubkey Jul 16, 2020
@tarcieri tarcieri merged commit c103631 into master Jul 16, 2020
@tarcieri tarcieri deleted the k256/ecdsa-recovery branch July 16, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants