x509-cert: adds a serial numbers generator #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
commented
Nov 26, 2023
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
from
f78f6bc
to
31a07a9
Compare
baloo
changed the title
baloo
changed the title
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
3 times, most recently
from
a81e1ac
to
38d4573
Compare
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
from
38d4573
to
4ba6d43
Compare
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
from
4ba6d43
to
f361e2e
Compare
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
2 times, most recently
from
8d6817b
to
f3471e7
Compare
tarcieri
reviewed
Dec 13, 2023
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
3 times, most recently
from
bae1b21
to
61f06d0
Compare
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
from
61f06d0
to
86c086b
Compare
This follows the CABF ballot 164 recommendation to have serials use 64 bits from a CSPRNG. This also provides the user with the option to prefix its values (for use of an instance id).
baloo
force-pushed
the
baloo/x509-cert/serial-number-generate
branch
from
86c086b
to
cb34750
Compare
baloo
commented
Jan 5, 2024
tarcieri
approved these changes
Jan 5, 2024
tarcieri
reviewed
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the CABF ballot 164 recommendation to have serials use 64 bits from a CSPRNG.
https://cabforum.org/2016/03/31/ballot-164/
This also provides the user with the option to prefix its values (for use of an instance id).