spki: streaming fingerprint builder #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the `Writer` trait to compute SPKI fingerprints by hashing output DER on-the-fly as opposed to encoding it first to an intermediate buffer then computing the SHA-256 digest. Besides simply being more efficient, the buffered method had a hardcoded limit of 4096-bytes. The new implementation has no such limit because it hashes data as soon as it's encoded. This additionally renames `SubjectPublicKeyInfo::fingerprint` to `::fingerprint_bytes`. "True" SPKI fingerprints are Base64-encoded, and this commit also promotes `fingerprint_base64` to being earlier in the impl block so it's the first fingerprinting method people see.
|
It might be interesting to make This works as a start, though. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
Writertrait to compute SPKI fingerprints by hashing output DER on-the-fly as opposed to encoding it first to an intermediate buffer then computing the SHA-256 digest.Besides simply being more efficient, the buffered method had a hardcoded limit of 4096-bytes. The new implementation has no such limit because it hashes data as soon as it's encoded.
This additionally renames
SubjectPublicKeyInfo::fingerprintto::fingerprint_bytes. "True" SPKI fingerprints are Base64-encoded, and this commit also promotesfingerprint_base64to being earlier in the impl block so it's the first fingerprinting method people see.