sha2: use stabilized core::arch::aarch64 intrinsics
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using inline assembly to "emulate" these intrinsics since the ones in `core::arch` had not yet been stabilized. Given the new 1.72 MSRV, we should now be able to use the intrinsics.
tarcieri
force-pushed
the
sha2/use-stable-aarch64-intrinsics
branch
from
e2c3ccc
to
9b624d6
Compare
|
My bad, I guess these aren't stabilized yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using inline assembly to "emulate" these intrinsics since the ones in
core::archhad not yet been stabilized.Given the new 1.72 MSRV, we should now be able to use the intrinsics.