Argon2: add constant for recommended salt length #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is identical to |
|
Oh, that's true, didn't notice that. Should I remove |
|
The latter (effectively re-exporting the constant) is fine. |
falko17
force-pushed
the
argon2-recommended-salt-length
branch
2 times, most recently
from
4db553c
to
7578316
Compare
|
Sorry for the notifications, I was stumbling around with the features a bit. I believe it should work now, though the new constant is only available if the |
falko17
force-pushed
the
argon2-recommended-salt-length
branch
from
161d74e
to
2cfe157
Compare
tarcieri
reviewed
Jun 8, 2022
The specification of argon2 recommends a salt length of 16 bytes for password hashing (section 3.1). This commit adds a constant to make this recommended salt length accessible to users by re-exporting `password_hash::Salt::RECOMMENDED_LENGTH`.
falko17
force-pushed
the
argon2-recommended-salt-length
branch
from
2cfe157
to
d298106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification of argon2 recommends a salt length of 16 bytes for password hashing (section 3.1).
This pull request introduces a constant
RECOMMENDED_SALT_LENto make this recommended salt length accessible to users.(Also, a slight mistake in the documentation has been corrected.)