Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLH-DSA #812

Merged
merged 3 commits into from
Apr 13, 2024
Merged

Add SLH-DSA #812

merged 3 commits into from
Apr 13, 2024

Conversation

tjade273
Copy link
Contributor

@tjade273 tjade273 commented Apr 4, 2024

This PR adds SLH-DSA to the signatures crate

The implementation is feature-complete and passing the KATs for all parameter sets. It should be useable with no-std, although the stack usage may be too large for most embedded devices.

Planed improvements:

  • Provide zero-copy and streaming interfaces in order to reduce stack usage
  • Reduce test run-time / factor into CI and release tests

slh-dsa/Cargo.lock Outdated Show resolved Hide resolved
slh-dsa/.gitignore Outdated Show resolved Hide resolved
@tarcieri
Copy link
Member

tarcieri commented Apr 4, 2024

What is archive.zip?

@tjade273
Copy link
Contributor Author

tjade273 commented Apr 4, 2024

What is archive.zip?

Just the git archive I used to move from the repo I was developing in, accidentally checked in. Removed

slh-dsa/src/xmss.rs Outdated Show resolved Hide resolved
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a caveat that the review is largely for style and consistency as I have only a cursory understanding of the various parts of this algorithm.

@tarcieri tarcieri merged commit 3697688 into RustCrypto:master Apr 13, 2024
41 checks passed
@tjade273 tjade273 deleted the slh-dsa branch April 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants