Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRV on cpufeatures broken by nightly cargo bug #795

Closed
TheBlueMatt opened this issue Aug 20, 2022 · 2 comments · Fixed by #796
Closed

MSRV on cpufeatures broken by nightly cargo bug #795

TheBlueMatt opened this issue Aug 20, 2022 · 2 comments · Fixed by #796

Comments

@TheBlueMatt
Copy link

When trying to build something that depends on cpufeatures on rustc 1.48, I get the following error from cargo. This appears to be an instance of rust-lang/cargo#10954, which means the cpufeatures crate simply needs to be re-uploaded with stable cargo (or a newer nightly).

error: failed to parse manifest at `/root/.cargo/registry/src/github.com-1ecc6299db9ec823/cpufeatures-0.2.3/Cargo.toml`

Caused by:
  feature `resolver` is required

  consider adding `cargo-features = ["resolver"]` to the manifest
striezel added a commit to striezel/corona that referenced this issue Aug 20, 2022
@striezel
dependencies: downgrade cpufeatures to 0.2.2
a5a9af9 
The cpufeatures 0.2.3 crate does not build on this project's
current MSRV (rustc 1.48), so it's reverted to the previous
version.

See <RustCrypto/utils#795> for the
corresponding upstream issue.
@newpavlov newpavlov mentioned this issue Aug 22, 2022
Merged
@newpavlov
Copy link
Member

Hm, it's weird that this issue did not trigger CI in the hashes repository which has MSRV 1.41. Either way, I will release v0.2.4 using the stable 1.63 toolchain right away. Can you confirm that v0.2.4 fixes your issue?

@striezel
Copy link
Contributor

Can you confirm that v0.2.4 fixes your issue?

I got the same issue as @TheBlueMatt, and for me cpufeatures 0.2.4 fixes the issue. Version 0.2.4 builds with rustc 1.48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cpufeatures: release v0.2.4 RustCrypto/utils
3 participants
@newpavlov @TheBlueMatt @striezel