Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert whats_left into a CPython script #2448

Merged

Conversation

verhovsky
Copy link
Contributor

so that we can parse command line options to configure what to print and how to print it.

@verhovsky verhovsky changed the title Convert whats_left into Python script Convert whats_left into a CPython script Feb 11, 2021
whats_left.py Outdated
@@ -1,3 +1,5 @@
#!/usr/bin/env python3

# It's recommended to run this with `python3 -I not_impl_gen.py`, to make sure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# It's recommended to run this with `python3 -I not_impl_gen.py`, to make sure
# It's recommended to run this with `python3 -I whats_left.py`, to make sure

@verhovsky verhovsky closed this Jul 23, 2022
@youknowone
Copy link
Member

oh, i liked this patch but it was forgotten. @verhovsky could you please open it again?

@verhovsky verhovsky reopened this Jul 23, 2022
@youknowone youknowone force-pushed the turn-whats-left-into-python-script branch 4 times, most recently from c5acc57 to 6d7e7fa Compare July 23, 2022 18:24
boris and others added 2 commits July 24, 2022 03:37
Co-Authored-By: Jeong YunWon <jeong@youknowone.org>
@youknowone youknowone force-pushed the turn-whats-left-into-python-script branch from 6d7e7fa to 3fdc409 Compare July 23, 2022 18:37
@youknowone youknowone requested a review from fanninpm July 23, 2022 18:38
@youknowone
Copy link
Member

@fanninpm please review again?

Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make it easier for people running Windows.

@youknowone youknowone marked this pull request as ready for review July 23, 2022 18:46
@youknowone
Copy link
Member

@verhovsky Thank you! and I am really sorry to forgetting this PR for long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants