Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize project layout #46

Merged
merged 10 commits into from
Sep 18, 2016

Conversation

ishkawa
Copy link
Member

@ishkawa ishkawa commented Sep 18, 2016

We should support Swift 3 as soon as possible, but we encounter trouble in running CI jobs.
To resolve this, I have made following changes:

  • Introduce Action.xcworkspace to build dependencies using git submodule.
    • Submodules are checked out by carthage update --use-submodules.
    • No tool update is required to follow Xcode update.
    • This layout is the same as that of ReactiveCocoa repository.
  • Merge Demo.xcodeproj into Action.xcodeproj.
  • Run CI jobs on Xcode 8.

@ashfurrow ashfurrow merged commit 95be402 into RxSwiftCommunity:master Sep 18, 2016
@ishkawa
Copy link
Member Author

ishkawa commented Sep 18, 2016

@ashfurrow Thank you for reviewing this PR ✨

Could you release current master as 1.3.0? It may be the last version which supports Swift 2.x, and there're some merged PRs which is not contained in version releases.

@ishkawa
Copy link
Member Author

ishkawa commented Sep 18, 2016

I noticed RxSwiftCommunity does not have write access to this repository, is it intended? Some other repositories give write access to the organization, and I think that is better to keep repository active.

@ashfurrow
Copy link
Member

Ah, no that's unintentional. Should be fixed now.

@ashfurrow
Copy link
Member

Ok, cool. I'll release 95be402 (master as of this merge) later this afternoon.

@ishkawa
Copy link
Member Author

ishkawa commented Sep 18, 2016

Great 👍 Thank you!

@ashfurrow
Copy link
Member

1.3.0 is released, is there any reason to wait before releasing a version for Swift 3?

@ishkawa
Copy link
Member Author

ishkawa commented Sep 19, 2016

Since the latest released of RxSwift for Swift 3 is still beta, I think our release for Swift 3 (possibly 2.0?) should also be beta.

@ashfurrow
Copy link
Member

Makes sense. So I should release a 2.0.0-beta.1 you think?

@ishkawa
Copy link
Member Author

ishkawa commented Sep 19, 2016

Yes 👍

@ashfurrow
Copy link
Member

Okay, pushed as 2.0.0-beta.1, let me know if you run into any issues, and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants