Fix missing watchOS target compile sources #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a Changelog entry ? Something like "Added missing sources for watchOS target" ? |
|
I'm actually wondering something. How did Travis work up until now if there is a problem with the target? 🤔 https://github.com/RxSwiftCommunity/Action/blob/master/.travis.yml#L8 |
|
Sorry! I added changelog 🚀 |
|
The watchOS test was running, but in reality it was working with empty sources targets 😢 |
freak4pc
approved these changes
May 28, 2017
|
This seems like a super minor change, I'll just go ahead and merge (no breaking changes or affecting previous builds in this case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing sources in the target of watchOS.
I think that can not use Carthage etc, so I fixed it.
Before
After