Updates to work with RxSwift 3.0.0 release #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has become private in RxSwift 3.0
|
is there anyway i can point to this branch before the pull request is accepted? would like to do some testing on my app. but can't build without this |
|
@chrisjrex you could use the master branch |
|
thanks |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the dependencies to use the 3.0.0 releases of RxSwift/RxCocoa - along with RxDataSources 1.0.0 in the example app.
It threw up a couple of minor syntax changes:
• creating
AnonymousDisposablescan now only be done viaDisposables.create•
self.tableView.rx.model(at: indexPath)needs the explicit "at" (this used in the example app)With the build setting for
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIESI've removed them again, erring on the side of stopping Cocoapods from complaining even though Xcode will disagree. You kinda can't win with this at the moment :/Updated the version number (0.3.0 without the rc bit). The podspec lints ok for me with Cocoapods 1.1.1 so should be good to go.