Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to be compatible with Nimble 6.1 & newer Swift #17

Merged
merged 6 commits into from
Apr 25, 2017
Merged

Updated to be compatible with Nimble 6.1 & newer Swift #17

merged 6 commits into from
Apr 25, 2017

Commits on Apr 25, 2017

  1. Update to Nimble 6.1 

    To solve RxSwiftCommunity#13
    @vhbit
    Rafael da Silva Ferreira authored and vhbit committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    fba37b9 View commit details
    Browse the repository at this point in the history

  2. Increase Nimble compatibility 

    To Nimble 6.0+.
    @RafaelPlantard @vhbit
    RafaelPlantard authored and vhbit committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    98dfe20 View commit details
    Browse the repository at this point in the history

  3. Add CocoaPods repo update 

    Based at RxSwiftCommunity#14 (comment).
    @RafaelPlantard @vhbit
    RafaelPlantard authored and vhbit committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    91c6de9 View commit details
    Browse the repository at this point in the history

  4. Fixed errors & warnings, changed equalFirst 

    1. It seems that nowadays Swift compiler can't deduce the right type
while going through `ObservableType`, as a temporary workaround I've
added implementation `==` for `Observable<T>` and `Observablle<T?>`
which should cover most cases.

2. `equalFirst` signature was simplified a bit to be more consistent
with other `Nimble` matchers. That might be a bit more verbose
`expect(something).to(equalFirst(expectedValue))` than
`expect(something) == expectedValue` but it also is more explicit. That
is API breaking change, so major version bumped, although it should be
easily fixed by search/replace.
    @vhbit
    vhbit committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    59bb147 View commit details
    Browse the repository at this point in the history

  5. Forgot to update lock file after bumping version

    @vhbit
    vhbit committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    237f599 View commit details
    Browse the repository at this point in the history

  6. Ok, while we here, let's also update cocoapods to latest release and … 

    …test against Xcode 8.3
    @vhbit
    vhbit committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    9a24a3f View commit details
    Browse the repository at this point in the history