Updated to be compatible with Nimble 6.1 & newer Swift #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To Nimble 6.0+.
1. It seems that nowadays Swift compiler can't deduce the right type while going through `ObservableType`, as a temporary workaround I've added implementation `==` for `Observable<T>` and `Observablle<T?>` which should cover most cases. 2. `equalFirst` signature was simplified a bit to be more consistent with other `Nimble` matchers. That might be a bit more verbose `expect(something).to(equalFirst(expectedValue))` than `expect(something) == expectedValue` but it also is more explicit. That is API breaking change, so major version bumped, although it should be easily fixed by search/replace.
…test against Xcode 8.3
|
cc @ashfurrow |
|
Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions. |
|
This has been pushed to CocoaPods trunk, thanks again 🙇 |
Closed
|
@vhbit awesome, congrats! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation of work started in #14. I've fixed all the warnings and provided a workaround for building errors through introducing a new
==operator (more details here: 59bb147). As API has a breaking change I've also bumped major version.