Thank you! ❤️ #3
Comments
|
Thoughts on merging one of your examples here back to https://github.com/vercel/next.js/tree/canary/examples/with-storybook |
|
Thanks so much! That means a lot! I'd be happy to merge in an example! Just to be clear, you want me to merge this in with the existing "with-storybook" example? Also would you like me to basically merge in my nextv12 example? It demos everything this supports but it isn't very pretty for sake of simplicity. As a side note, how did you find out about this addon? I'm still amazed at how fast word spreads in open source. |
RyanClementsHax
added
the
documentation
|
Yeah, I'd say moving https://github.com/RyanClementsHax/storybook-addon-next/tree/main/examples/nextv12 to |
…he with-storybook example (#33891) - use the nextv12 example from the storybook-addon-next repo as the with-storybook example found here: https://github.com/RyanClementsHax/storybook-addon-next/tree/6583c2080386f72fdebc49ff93a2b8262d1219bc/examples/nextv12 - update the readme for the example to include details on what the example includes - tweak the example from the `storybook-addon-next` repo to work with type checking and linting Resolves #33889 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` ## Context This was kindly requested by @leerob in [this issue](RyanClementsHax/storybook-addon-next#3) on the `storybook-addon-next` repo. P.S. thanks to @leerob for making [this video](https://www.youtube.com/watch?v=cuoNzXFLitc&t=1502s). I found it very helpful for getting me up to speed with how to contribute. I hope I did everything right for y'all. Lmk if there was something I could have done better.
…he with-storybook example (vercel#33891) - use the nextv12 example from the storybook-addon-next repo as the with-storybook example found here: https://github.com/RyanClementsHax/storybook-addon-next/tree/6583c2080386f72fdebc49ff93a2b8262d1219bc/examples/nextv12 - update the readme for the example to include details on what the example includes - tweak the example from the `storybook-addon-next` repo to work with type checking and linting Resolves vercel#33889 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` ## Context This was kindly requested by @leerob in [this issue](RyanClementsHax/storybook-addon-next#3) on the `storybook-addon-next` repo. P.S. thanks to @leerob for making [this video](https://www.youtube.com/watch?v=cuoNzXFLitc&t=1502s). I found it very helpful for getting me up to speed with how to contribute. I hope I did everything right for y'all. Lmk if there was something I could have done better.
Just wanted to say thank you for creating this - it's awesome!
The text was updated successfully, but these errors were encountered: