-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: use storybook-addon-next for the with-storybook example project #33889
Labels
Comments
1 task
Thank you so much! |
kodiakhq bot
pushed a commit
that referenced
this issue
Feb 6, 2022
…he with-storybook example (#33891) - use the nextv12 example from the storybook-addon-next repo as the with-storybook example found here: https://github.com/RyanClementsHax/storybook-addon-next/tree/6583c2080386f72fdebc49ff93a2b8262d1219bc/examples/nextv12 - update the readme for the example to include details on what the example includes - tweak the example from the `storybook-addon-next` repo to work with type checking and linting Resolves #33889 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` ## Context This was kindly requested by @leerob in [this issue](RyanClementsHax/storybook-addon-next#3) on the `storybook-addon-next` repo. P.S. thanks to @leerob for making [this video](https://www.youtube.com/watch?v=cuoNzXFLitc&t=1502s). I found it very helpful for getting me up to speed with how to contribute. I hope I did everything right for y'all. Lmk if there was something I could have done better.
natew
pushed a commit
to natew/next.js
that referenced
this issue
Feb 16, 2022
…he with-storybook example (vercel#33891) - use the nextv12 example from the storybook-addon-next repo as the with-storybook example found here: https://github.com/RyanClementsHax/storybook-addon-next/tree/6583c2080386f72fdebc49ff93a2b8262d1219bc/examples/nextv12 - update the readme for the example to include details on what the example includes - tweak the example from the `storybook-addon-next` repo to work with type checking and linting Resolves vercel#33889 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` ## Context This was kindly requested by @leerob in [this issue](RyanClementsHax/storybook-addon-next#3) on the `storybook-addon-next` repo. P.S. thanks to @leerob for making [this video](https://www.youtube.com/watch?v=cuoNzXFLitc&t=1502s). I found it very helpful for getting me up to speed with how to contribute. I hope I did everything right for y'all. Lmk if there was something I could have done better.
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
What is the improvement or update you wish to see?
Improve the
with-storybook
example by using the example provided in the storybook-addon-next repo.Is there any context that might help us understand?
This was kindly requested by @leerob in this issue on the
storybook-addon-next
repo.Does the docs page already exist? Please link to it.
https://github.com/vercel/next.js/tree/canary/examples/with-storybook
The text was updated successfully, but these errors were encountered: