Self feedback

Ryujinx · Jan 12, 2023 · a75cc41 · a75cc41
1 parent a68dd53
commit a75cc41
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/Ryujinx.Graphics.Shader/CodeGen/Spirv/Instructions.cs b/Ryujinx.Graphics.Shader/CodeGen/Spirv/Instructions.cs
@@ -2194,19 +2194,23 @@ private static SpvInstruction GetStorageElemPointer(CodeGenContext context, AstO
             if (operation.Inst.HasFlag(Instruction.FP64))
             {
                 var result = emitF(context.TypeFP64(), context.GetFP64(src1), context.GetFP64(src2));
+
                 if (!context.Config.GpuAccessor.QueryHostReducedPrecision())
                 {
                     context.Decorate(result, Decoration.NoContraction);
                 }
+
                 return new OperationResult(AggregateType.FP64, result);
             }
             else if (operation.Inst.HasFlag(Instruction.FP32))
             {
                 var result = emitF(context.TypeFP32(), context.GetFP32(src1), context.GetFP32(src2));
+
                 if (!context.Config.GpuAccessor.QueryHostReducedPrecision())
                 {
                     context.Decorate(result, Decoration.NoContraction);
                 }
+
                 return new OperationResult(AggregateType.FP32, result);
             }
             else
@@ -2261,19 +2265,23 @@ private static SpvInstruction GetStorageElemPointer(CodeGenContext context, AstO
             if (operation.Inst.HasFlag(Instruction.FP64))
             {
                 var result = emitF(context.TypeFP64(), context.GetFP64(src1), context.GetFP64(src2), context.GetFP64(src3));
+
                 if (!context.Config.GpuAccessor.QueryHostReducedPrecision())
                 {
                     context.Decorate(result, Decoration.NoContraction);
                 }
+
                 return new OperationResult(AggregateType.FP64, result);
             }
             else if (operation.Inst.HasFlag(Instruction.FP32))
             {
                 var result = emitF(context.TypeFP32(), context.GetFP32(src1), context.GetFP32(src2), context.GetFP32(src3));
+
                 if (!context.Config.GpuAccessor.QueryHostReducedPrecision())
                 {
                     context.Decorate(result, Decoration.NoContraction);
                 }
+
                 return new OperationResult(AggregateType.FP32, result);
             }
             else

diff --git a/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs b/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs
@@ -12,9 +12,7 @@ enum PortabilitySubsetFlags
         NoTriangleFans = 1 << 1,
         NoPointMode = 1 << 2,
         No3DImageView = 1 << 3,
-        NoLodBias = 1 << 4,
-
-        MoltenVK = VertexBufferAlignment4B | NoTriangleFans | NoPointMode | No3DImageView | NoLodBias
+        NoLodBias = 1 << 4
     }
 
     readonly struct HardwareCapabilities

diff --git a/Ryujinx.Graphics.Vulkan/HelperShader.cs b/Ryujinx.Graphics.Vulkan/HelperShader.cs
@@ -986,6 +986,8 @@ protected virtual void Dispose(bool disposing)
                 _programColorBlitClearAlpha.Dispose();
                 _programColorBlit.Dispose();
                 _programColorClearF.Dispose();
+                _programColorClearSI.Dispose();
+                _programColorClearUI.Dispose();
                 _programStrideChange.Dispose();
                 _programConvertIndexBuffer.Dispose();
                 _programConvertIndirectData.Dispose();

diff --git a/Ryujinx.Graphics.Vulkan/MoltenVK/MVKConfiguration.cs b/Ryujinx.Graphics.Vulkan/MoltenVK/MVKConfiguration.cs
@@ -100,6 +100,5 @@ struct MVKConfiguration
         public MVKConfigAdvertiseExtensions AdvertiseExtensions;
         public Bool32 ResumeLostDevice;
         public Bool32 UseMetalArgumentBuffers;
-
     }
 }
diff --git a/Ryujinx.Graphics.Vulkan/Vendor.cs b/Ryujinx.Graphics.Vulkan/Vendor.cs
@@ -36,7 +36,7 @@ public static string GetNameFromId(uint id)
             {
                 0x1002 => "AMD",
                 0x1010 => "ImgTec",
-                0x106B => "MoltenVK",
+                0x106B => "Apple",
                 0x10DE => "NVIDIA",
                 0x13B5 => "ARM",
                 0x1AE0 => "Google",