Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ava UI: Text alignment issues on non Windows platforms [Fixed in V2] #3970

Closed
IsaacMarovitz opened this issue Dec 1, 2022 · 2 comments · Fixed by #4362
Closed

Ava UI: Text alignment issues on non Windows platforms [Fixed in V2] #3970

IsaacMarovitz opened this issue Dec 1, 2022 · 2 comments · Fixed by #4362
Labels
blocked Blocked by something bug Something isn't working gui Related to Ryujinx.Ui

Comments

@IsaacMarovitz
Copy link
Member

IsaacMarovitz commented Dec 1, 2022

There is a series of issues regarding text alignment issues in FluentAvalonia on non-Windows platforms. FluentAvalonia v2, which should be released soon, contains a fix for this issue, TextVerticalAlignmentOverrideBehavior.

I have done a quick build with the preview version of FluentAvalonia v2 and confirmed that this solves the issue.

I'm making this issue for tracking this problem, as some work will be required to convert to v2 when it releases.

Notably, some controls, like Search are not fixed by v2 and will probably need work on our side.

@AcK77
Copy link
Member

AcK77 commented Dec 1, 2022

It's not possible to do a temporary fix on our side until the v2 of FluentAvalonia is out?
We can remove the fix later and then keep going on other changes.

@AcK77 AcK77 added bug Something isn't working gui Related to Ryujinx.Ui labels Dec 1, 2022
@IsaacMarovitz
Copy link
Member Author

@AcK77 I tried to make patches but Avalonia ignored my Style selectors even though they showed up in the dev tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by something bug Something isn't working gui Related to Ryujinx.Ui
Projects
None yet
3 participants