Ava UI: Avalonia 11 & FluentAvalonia 2 Support #4362

IsaacMarovitz · 2023-02-03T15:14:17Z

One step closer to getting rid of GTK.

The purpose of this PR is to get everything running as it was in Avalonia 11, with no warnings. Further code improvements and fixes to take advantage of newer APIs will come in future PRs for the sake of simplicity.

Changes:

Enables CompiledBindings by default
Fixes janky TextBox
Fixes janky ToggleButton
Fixes janky CheckBox
Changes to new renderer
Fixes performance issues with Ava in Windowed mode
Windows: Titlebar colour matches theme
Mac: Fixes Ava UI: Text alignment issues on non Windows platforms [Fixed in V2] #3970
Linux: KDE file picker used instead of GNOME

TODO:

Superceeds part of #3997

github-actions · 2023-02-03T15:38:32Z

Download the artifacts for this pull request:

Experimental GUI (Avalonia)

GUI-less (SDL2)

Only for Developers

marysaka · 2023-02-03T18:05:26Z

Also required for XDG Portal support (needed for Flatpack builds)

TSRBerry · 2023-02-06T23:29:34Z

Mark this as ready for review as soon as you finished all your TODOs. Otherwise we won't know when you actually want us to review stuff.

IsaacMarovitz · 2023-02-07T03:36:18Z

@emmauss I'd appreciate your help with some of the TODO items

distribution/linux/mime/Ryujinx.xml

distribution/macos/Info.plist

IsaacMarovitz · 2023-05-16T14:58:05Z

Okay, there are a couple remaining issues, one of which is dependant on FluentAvalonia updating, but I'm going to open this up to review since everything else should be working as expected and there are quite a few changes in this PR.

EDIT :trauma:

hez2010 · 2023-08-02T14:27:37Z

Whats the problem with the settings window

After opening then closing the settings window, RyuJinx starts to stop processing all inputs to the game.

Steps to reproduce:

Start a game
Open and then close the settings window
The game no longer processes any input from controllers

IsaacMarovitz · 2023-08-02T17:06:27Z

@hez2010 Changes to input have been made. Please double-check if this still occurs in the latest build artefacts. What operating system are you on?

GamerzHell9137 · 2023-08-02T17:23:18Z

Input fixed on Windows 10.

hez2010 · 2023-08-02T23:37:49Z

@hez2010 Changes to input have been made. Please double-check if this still occurs in the latest build artefacts. What operating system are you on?

It works. I didn't pull the latest changes.

TSRBerry · 2023-08-10T22:01:34Z

GUI only tests/review:

✅ Game icons are sharper

✅ Window icon looks correct now

⚠️ About window looks a little wrong now

Old:
New:

❓ File picker uses default window title and icon

Could that be changed?

⚠️ Settings window: User interface - too large for the window size

⚠️ Hovering over dialog buttons doesn't turn them blue anymore

⛔ Toast notifications don't work anymore

Old:

⚠️ User profile manager: Typo

This is also the case on master, I just noticed it here.

⚠️ Save Manager: Game icons look wrong

Old (also doesn't look quite right):
New:

⚠️ User profile manager: Firmware avatars look wrong

Old:
New:

Overall, everything feels a lot smoother and faster than Avalonia 10! There are still some improvements we can make so it also doesn't feel slow in these areas anymore, like async game loading (which we had before, but it has been gone for some time now) and async settings loading. But I think we already have open PRs for these as well, so these issues won't be here for long.

As soon as this PR is merged, I'd like to start switching to Avalonia for our default GUI if @Ryujinx/developers are okay with that! :D

💔 Gamescope test results

Sadly the issues we had before aren't fixed with Ava11.

The context menus won't show up
Opening dropdowns opens a very large rectangle for a split second before it vanishes. The mouse goes all over the place while this happens.
Using the touchscreen I'm unable to click on items in the menubar, the mouse gets stuck and vanishes. Moving the mouse over games (using the touchscreen) makes it visible again.

But I don't think this should stop us from merging this and making Avalonia the default GUI soon. People using Ryujinx on the Steam Deck in gaming mode should be using the headless version anyway.

We are talking about gamescope issues here, since other window managers have no trouble with Avalonia and behave correctly. We should consider opening an issue about that on their repository.

IsaacMarovitz · 2023-08-10T23:35:49Z

@TSRBerry

RE - `Game icons are sharper`, `Save Manager: Game icons look wrong` and `User profile manager: Firmware avatars look wrong`

All of these are due to changes in how Avalonia 11 does bitmap rendering.
I tested out a number of smoothing options and queried devs for opinions and the consensus was that I leave it at the default, which results in no smoothing.
The new smoothing algorithm feels a lot worse than the old algorithm with basically 0 customisation, and you end up losing a lot of the fine detail in the images

RE - `User profile manager: Typo`

This PR is intended only to get Avalonia working to the same state as it currently is on master

RE - `Settings window: User interface - too large for the window size`

Resolved on my machine by latest dependency bump commit.

RE - `File picker uses default window title and icon`

Unfortunately, this is not possible with the current API.

RE - `About window looks a little wrong now`

Fix pushed.

RE - `Toast notifications don't work anymore`

Fix pushed.

src/Ryujinx.Ava/Ryujinx.Ava.csproj

TSRBerry

Awesome work, thank you very much!

I commented a few questions and found a few stylistic things that would be nice to change as well.
But other than that I don't see how we could stall this PR any longer. :D

distribution/macos/Info.plist

src/Ryujinx.Ava/Assets/Styles/Styles.xaml

src/Ryujinx.Ava/Common/ApplicationHelper.cs

src/Ryujinx.Ava/app.manifest

src/Ryujinx.Ava/AppHost.cs

src/Ryujinx.Ava/Ryujinx.Ava.csproj

distribution/macos/Info.plist

TSRBerry

After these ones there should be nothing left 😅

src/Ryujinx.Ava/AppHost.cs

src/Ryujinx.Ava/Assets/Styles/Themes.xaml

TSRBerry

Lgtm, thank you for your work! :D

* It builds (Doesn’t run waiting on FluentAvalonia Preview 5 Release) * Enable CompiledBindings by default * Ignore `PointerPressedEventArgs` Init warning * Define MIME and UTI Types * Update `UserProfileImageSelectorView` to StorageProvider API * PFS0 Magic * Update `MainWindowViewModel` to StorageProvider API * Update `SettingsUIView` to StorageProvider API * Update `ApplicationHelper` to StorageProvider API * Use `IsCheckChanged` * Rename events * Update Fluent Avalonia to Preivew 5 * More package updates * Fix long selection bar * return glyph value directly, instead of using a binding * fix menu item checkboxes * Fix build * Update to Preview 6 Unicorn conflict Fix remaining package oopsie * Fix issues from merge * Fix some warnings * Warnings * Squashed commit of the following: commit 79d1c19 Author: Mary <mary@mary.zone> Date: Sun Apr 16 11:38:07 2023 +0200 chore: Update Silk.NET to 2.17.1 (Ryujinx#4686) commit 2bc8846 Author: Ac_K <Acoustik666@gmail.com> Date: Sun Apr 16 09:37:31 2023 +0000 Update README.md commit baf8752 Author: Vincenzo Nizza <vincenzonizzaufficio@gmail.com> Date: Sun Apr 16 11:19:33 2023 +0200 Ensure the updater doesn't delete hidden or system files (Ryujinx#4626) * Copy desktop.ini to update directory if it exists in HomeDir * EnumerateFilesToDelete() exclude files with "Hidden" and "System" attributes commit d5e4378 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Apr 16 09:02:06 2023 +0000 nuget: bump DynamicData from 7.13.1 to 7.13.5 (Ryujinx#4654) Bumps [DynamicData](https://github.com/reactiveui/DynamicData) from 7.13.1 to 7.13.5. - [Release notes](https://github.com/reactiveui/DynamicData/releases) - [Changelog](https://github.com/reactivemarbles/DynamicData/blob/main/ReleaseNotes.md) - [Commits](reactivemarbles/DynamicData@7.13.1...7.13.5) --- updated-dependencies: - dependency-name: DynamicData dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6dbcdfe Author: TSRBerry <20988865+TSRBerry@users.noreply.github.com> Date: Sun Apr 16 09:09:02 2023 +0200 Ava: Fix nca extraction window never closing & minor cleanup (Ryujinx#4569) * ava: Remove unused doWhileDeferred parameters * ava: Minimally improve swkbd dialog It's currently impossible to get the dialog to redirect focus to the InputBox. * ava: Fix nca extraction dialog never closing Also contains some minor cleanup commit c5258cf Author: NitroTears <73270647+NitroTears@users.noreply.github.com> Date: Sun Apr 16 11:03:35 2023 +1000 Ability to hide file types in Game List (Ryujinx#4555) * Added HiddenFileTypes to config state, and check to file enumeration * Added hiddenfiletypes checkboxes to the UI * Added Ava version of HiddenFileTypes * Inverted Hide to Show with file types, minor formatting * all variables with a reference to 'hidden' is now 'shown' * one more variable name changed * review feedback * added FileTypes extension methof to get the correlating config value * moved extension method to new folder and file in Ryujinx.Ui.Common * added default case for ToggleFileType * changed exception type to OutOfRangeException commit 5c89e22 Author: Daniel Shala <daniel.shala08@gmail.com> Date: Sat Apr 15 18:11:24 2023 +0200 Added check for eventual symlink when displaying game files. (Ryujinx#4526) * Added check for eventual symlink when displaying game files. * Moved symlink check logic * Moved symlink check logic * Fixed prev commit --------- Co-authored-by: Daniel Shala <danielshala00@gmail.com> commit 11ecff2 Author: Alex Barney <thealexbarney@gmail.com> Date: Fri Apr 14 16:00:34 2023 -0700 Rename Hipc to Cmif where appropriate (Ryujinx#3880) commit 4c3f096 Author: MutantAura <44103205+MutantAura@users.noreply.github.com> Date: Wed Apr 12 20:18:40 2023 +0100 Move swkbd message null check into constructor (Ryujinx#4671) commit e187a88 Author: TSRBerry <20988865+TSRBerry@users.noreply.github.com> Date: Wed Apr 12 03:09:47 2023 +0200 HLE: Deal with empty title names properly (Ryujinx#4643) * hle: Deal with empty titleNames in some languages * gui: Fix displaying the wrong title name * Remove unnecessary bounds check * Fix a NRE when getting the version string * Restore empty string logic commit a64fee2 Author: riperiperi <rhy3756547@hotmail.com> Date: Tue Apr 11 08:23:41 2023 +0100 Vulkan: add situational "Fast Flush" mode (Ryujinx#4667) * Flush in the middle of long command buffers. * Vulkan: add situational "Fast Flush" mode The AutoFlushCounter class was added to periodically flush Vulkan command buffers throughout a frame, which reduces latency to the GPU as commands are submitted and processed much sooner. This was done by allowing command buffers to flush when framebuffer attachments changed. However, some games have incredibly long render passes with a large number of draws, and really aggressive data access that forces GPU sync. The Vulkan backend could potentially end up building a single command buffer for 4-5ms if a pass has enough draws, such as in BOTW. In the scenario where sync is waited on immediately after submission, this would have to wait for the completion of a much longer command buffer than usual. The solution is to force command buffer submission periodically in a "fast flush" mode. This will end up splitting render passes, but it will only enable if sync is aggressive enough. This should improve performance in GPU limited scenarios, or in games that aggressively wait on synchronization. In some games, it may only kick in when res scaling. It won't trigger in games like SMO where sync is not an issue. Improves performance in Pokemon Scarlet/Violet (res scaled) and BOTW (in general). * Add conversions in milliseconds next to flush timers. commit 9ef94c8 Author: riperiperi <rhy3756547@hotmail.com> Date: Tue Apr 11 07:55:04 2023 +0100 ARMeilleure: Move TPIDR_EL0 and TPIDRRO_EL0 to NativeContext (Ryujinx#4661) * ARMeilleure: Move TPIDR_EL0 and TPIDRRO_EL0 to NativeContext Some games access these system registers several tens of thousands of times in a second from many different threads. While this isn't really crippling, it is a lot of wasted time spent in a reverse pinvoke transition. Example games are Pokemon Scarlet/Violet and BOTW. These games have a lot of different potential bottlenecks so it's unlikely you will see a consistent improvement, but it definitely disappears from the cpu profile. * Remove unreachable code. * Add ulong conversion for offsets * Nit commit 915d6d0 Author: riperiperi <rhy3756547@hotmail.com> Date: Tue Apr 11 07:32:31 2023 +0100 OpenGL: Fix OBS/Overlays again by binding FB before present (Ryujinx#4668) This seems to have been removed by the Post-Processing PR, but it is required for the display in OBS to be the right way up and properly scaled. I've tested this with AA and FSR on MK8D and it seems to behave properly. Testing is welcome. commit a4780ab Author: MutantAura <44103205+MutantAura@users.noreply.github.com> Date: Mon Apr 10 23:04:31 2023 +0100 Force activate parent window before dialog is shown (Ryujinx#4663) * Fix build Extraction dialogue not working * Avalonia Preview 7 Needs Fluent Avalonia update still… * Fix Render Scaling * Update Fluent Avalonia * Remove `pfs0` as runnable file type * Restore Info.plist formatting * Plist Format * Update Avalonia.Svg.Skia * Update theme code (TODO) * swtich to using theme variants for light dark * Fix crashes * Text centering issues * Update `TitleUpdateViewModel` to StorageProvider API * Fixed for new PR (Will crash on launch) * Fixes… * UI: Fix sections extraction (Ryujinx#4820) * UI: Fix sections extraction There is currently an issue when the update NCA doesn't contains the section we want to extract, this is fixed by adding a check. I have fixed the inverted handler of ExeFs/Logo introduced in Ryujinx#4755. Fixes Ryujinx#4521 * Addresses feedback * Fix issues… * Preview 8 * Fix fuck ups * Fixes * More cleanup * Ava 11 RC Maybe there is a god * Update FluentAvalonia * update svg * Second RC (kill me) * It builds * Ava 11 * Remove unnecessary usings * Fix build * Formatting * GAS GAS GAS!!!! * Fix DLC Window Crash * Linux runner try not to crash challenge (impossible) * Add app.manifest * Fix accidental Silk.NET.Vulkan bump * Try fix truncation * Linux fix popup Windows * Fix cutoff text on windows * Status bar styling fixes * Volume Toggle Split Button Fixes * Fix load bar color * Fix shortcuts * Best we're gonna get * Fix spacing Co-authored-by: Exhigh <exhigh01@gmail.com> * Formatting * Fix Profile Dropdown * Fix Window Startup Position * Format Fixes * Fix stupid mistake * Fix accidental change * Scaling Handler (peri pls make sure is working) * Remove Locale Reflection Binding Use + Unsued Usings * Fix formatting Code styling Ughhhh Fix interface Make TimeZoneConverter internal * Remove bell workaround (no longer needed) * Disable accent menu * Update to Ava 11.0.2 * Peri suggestions * Formatting * Cleanup a bunch of jank * Dependency update * Berry fixes and suggestions * Final suggestions * Rename assemblyIdentity to Ryujinx.Emulator.Avalonia --------- Co-authored-by: Emmanuel Hansen <emmausssss@gmail.com> Co-authored-by: Ac_K <Acoustik666@gmail.com> Co-authored-by: Exhigh <exhigh01@gmail.com> Co-authored-by: TSR Berry <20988865+TSRBerry@users.noreply.github.com>

Narugakuruga · 2023-08-13T03:29:50Z

Updater now crash after this PR.
Often happens when downloading update for more than 30 seconds (on slow internet connection).

TSRBerry · 2023-08-13T20:39:31Z

Could you please upload a log which contains the crash?

* It builds (Doesn’t run waiting on FluentAvalonia Preview 5 Release) * Enable CompiledBindings by default * Ignore `PointerPressedEventArgs` Init warning * Define MIME and UTI Types * Update `UserProfileImageSelectorView` to StorageProvider API * PFS0 Magic * Update `MainWindowViewModel` to StorageProvider API * Update `SettingsUIView` to StorageProvider API * Update `ApplicationHelper` to StorageProvider API * Use `IsCheckChanged` * Rename events * Update Fluent Avalonia to Preivew 5 * More package updates * Fix long selection bar * return glyph value directly, instead of using a binding * fix menu item checkboxes * Fix build * Update to Preview 6 Unicorn conflict Fix remaining package oopsie * Fix issues from merge * Fix some warnings * Warnings * Squashed commit of the following: commit 79d1c19 Author: Mary <mary@mary.zone> Date: Sun Apr 16 11:38:07 2023 +0200 chore: Update Silk.NET to 2.17.1 (Ryujinx#4686) commit 2bc8846 Author: Ac_K <Acoustik666@gmail.com> Date: Sun Apr 16 09:37:31 2023 +0000 Update README.md commit baf8752 Author: Vincenzo Nizza <vincenzonizzaufficio@gmail.com> Date: Sun Apr 16 11:19:33 2023 +0200 Ensure the updater doesn't delete hidden or system files (Ryujinx#4626) * Copy desktop.ini to update directory if it exists in HomeDir * EnumerateFilesToDelete() exclude files with "Hidden" and "System" attributes commit d5e4378 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Apr 16 09:02:06 2023 +0000 nuget: bump DynamicData from 7.13.1 to 7.13.5 (Ryujinx#4654) Bumps [DynamicData](https://github.com/reactiveui/DynamicData) from 7.13.1 to 7.13.5. - [Release notes](https://github.com/reactiveui/DynamicData/releases) - [Changelog](https://github.com/reactivemarbles/DynamicData/blob/main/ReleaseNotes.md) - [Commits](reactivemarbles/DynamicData@7.13.1...7.13.5) --- updated-dependencies: - dependency-name: DynamicData dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6dbcdfe Author: TSRBerry <20988865+TSRBerry@users.noreply.github.com> Date: Sun Apr 16 09:09:02 2023 +0200 Ava: Fix nca extraction window never closing & minor cleanup (Ryujinx#4569) * ava: Remove unused doWhileDeferred parameters * ava: Minimally improve swkbd dialog It's currently impossible to get the dialog to redirect focus to the InputBox. * ava: Fix nca extraction dialog never closing Also contains some minor cleanup commit c5258cf Author: NitroTears <73270647+NitroTears@users.noreply.github.com> Date: Sun Apr 16 11:03:35 2023 +1000 Ability to hide file types in Game List (Ryujinx#4555) * Added HiddenFileTypes to config state, and check to file enumeration * Added hiddenfiletypes checkboxes to the UI * Added Ava version of HiddenFileTypes * Inverted Hide to Show with file types, minor formatting * all variables with a reference to 'hidden' is now 'shown' * one more variable name changed * review feedback * added FileTypes extension methof to get the correlating config value * moved extension method to new folder and file in Ryujinx.Ui.Common * added default case for ToggleFileType * changed exception type to OutOfRangeException commit 5c89e22 Author: Daniel Shala <daniel.shala08@gmail.com> Date: Sat Apr 15 18:11:24 2023 +0200 Added check for eventual symlink when displaying game files. (Ryujinx#4526) * Added check for eventual symlink when displaying game files. * Moved symlink check logic * Moved symlink check logic * Fixed prev commit --------- Co-authored-by: Daniel Shala <danielshala00@gmail.com> commit 11ecff2 Author: Alex Barney <thealexbarney@gmail.com> Date: Fri Apr 14 16:00:34 2023 -0700 Rename Hipc to Cmif where appropriate (Ryujinx#3880) commit 4c3f096 Author: MutantAura <44103205+MutantAura@users.noreply.github.com> Date: Wed Apr 12 20:18:40 2023 +0100 Move swkbd message null check into constructor (Ryujinx#4671) commit e187a88 Author: TSRBerry <20988865+TSRBerry@users.noreply.github.com> Date: Wed Apr 12 03:09:47 2023 +0200 HLE: Deal with empty title names properly (Ryujinx#4643) * hle: Deal with empty titleNames in some languages * gui: Fix displaying the wrong title name * Remove unnecessary bounds check * Fix a NRE when getting the version string * Restore empty string logic commit a64fee2 Author: riperiperi <rhy3756547@hotmail.com> Date: Tue Apr 11 08:23:41 2023 +0100 Vulkan: add situational "Fast Flush" mode (Ryujinx#4667) * Flush in the middle of long command buffers. * Vulkan: add situational "Fast Flush" mode The AutoFlushCounter class was added to periodically flush Vulkan command buffers throughout a frame, which reduces latency to the GPU as commands are submitted and processed much sooner. This was done by allowing command buffers to flush when framebuffer attachments changed. However, some games have incredibly long render passes with a large number of draws, and really aggressive data access that forces GPU sync. The Vulkan backend could potentially end up building a single command buffer for 4-5ms if a pass has enough draws, such as in BOTW. In the scenario where sync is waited on immediately after submission, this would have to wait for the completion of a much longer command buffer than usual. The solution is to force command buffer submission periodically in a "fast flush" mode. This will end up splitting render passes, but it will only enable if sync is aggressive enough. This should improve performance in GPU limited scenarios, or in games that aggressively wait on synchronization. In some games, it may only kick in when res scaling. It won't trigger in games like SMO where sync is not an issue. Improves performance in Pokemon Scarlet/Violet (res scaled) and BOTW (in general). * Add conversions in milliseconds next to flush timers. commit 9ef94c8 Author: riperiperi <rhy3756547@hotmail.com> Date: Tue Apr 11 07:55:04 2023 +0100 ARMeilleure: Move TPIDR_EL0 and TPIDRRO_EL0 to NativeContext (Ryujinx#4661) * ARMeilleure: Move TPIDR_EL0 and TPIDRRO_EL0 to NativeContext Some games access these system registers several tens of thousands of times in a second from many different threads. While this isn't really crippling, it is a lot of wasted time spent in a reverse pinvoke transition. Example games are Pokemon Scarlet/Violet and BOTW. These games have a lot of different potential bottlenecks so it's unlikely you will see a consistent improvement, but it definitely disappears from the cpu profile. * Remove unreachable code. * Add ulong conversion for offsets * Nit commit 915d6d0 Author: riperiperi <rhy3756547@hotmail.com> Date: Tue Apr 11 07:32:31 2023 +0100 OpenGL: Fix OBS/Overlays again by binding FB before present (Ryujinx#4668) This seems to have been removed by the Post-Processing PR, but it is required for the display in OBS to be the right way up and properly scaled. I've tested this with AA and FSR on MK8D and it seems to behave properly. Testing is welcome. commit a4780ab Author: MutantAura <44103205+MutantAura@users.noreply.github.com> Date: Mon Apr 10 23:04:31 2023 +0100 Force activate parent window before dialog is shown (Ryujinx#4663) * Fix build Extraction dialogue not working * Avalonia Preview 7 Needs Fluent Avalonia update still… * Fix Render Scaling * Update Fluent Avalonia * Remove `pfs0` as runnable file type * Restore Info.plist formatting * Plist Format * Update Avalonia.Svg.Skia * Update theme code (TODO) * swtich to using theme variants for light dark * Fix crashes * Text centering issues * Update `TitleUpdateViewModel` to StorageProvider API * Fixed for new PR (Will crash on launch) * Fixes… * UI: Fix sections extraction (Ryujinx#4820) * UI: Fix sections extraction There is currently an issue when the update NCA doesn't contains the section we want to extract, this is fixed by adding a check. I have fixed the inverted handler of ExeFs/Logo introduced in Ryujinx#4755. Fixes Ryujinx#4521 * Addresses feedback * Fix issues… * Preview 8 * Fix fuck ups * Fixes * More cleanup * Ava 11 RC Maybe there is a god * Update FluentAvalonia * update svg * Second RC (kill me) * It builds * Ava 11 * Remove unnecessary usings * Fix build * Formatting * GAS GAS GAS!!!! * Fix DLC Window Crash * Linux runner try not to crash challenge (impossible) * Add app.manifest * Fix accidental Silk.NET.Vulkan bump * Try fix truncation * Linux fix popup Windows * Fix cutoff text on windows * Status bar styling fixes * Volume Toggle Split Button Fixes * Fix load bar color * Fix shortcuts * Best we're gonna get * Fix spacing Co-authored-by: Exhigh <exhigh01@gmail.com> * Formatting * Fix Profile Dropdown * Fix Window Startup Position * Format Fixes * Fix stupid mistake * Fix accidental change * Scaling Handler (peri pls make sure is working) * Remove Locale Reflection Binding Use + Unsued Usings * Fix formatting Code styling Ughhhh Fix interface Make TimeZoneConverter internal * Remove bell workaround (no longer needed) * Disable accent menu * Update to Ava 11.0.2 * Peri suggestions * Formatting * Cleanup a bunch of jank * Dependency update * Berry fixes and suggestions * Final suggestions * Rename assemblyIdentity to Ryujinx.Emulator.Avalonia --------- Co-authored-by: Emmanuel Hansen <emmausssss@gmail.com> Co-authored-by: Ac_K <Acoustik666@gmail.com> Co-authored-by: Exhigh <exhigh01@gmail.com> Co-authored-by: TSR Berry <20988865+TSRBerry@users.noreply.github.com>

IsaacMarovitz mentioned this pull request Feb 3, 2023

Ava GUI: Avalonia 11 & FluentAvalonia 2 Support #3997

Closed

IsaacMarovitz changed the title ~~Ava GUI: Avalonia 11 & FluentAvalonia 2 Support~~ Ava UI: Avalonia 11 & FluentAvalonia 2 Support Feb 3, 2023

IsaacMarovitz mentioned this pull request Feb 3, 2023

Ava UI: Remove all remaining uses of ReflectionBinding #4363

Closed

5 tasks

marysaka requested review from AcK77, emmauss, TSRBerry and marysaka February 3, 2023 18:03

marysaka added gui Related to Ryujinx.Ui miscellaneous Related to some project not listed in labels needs-feedback The needs feedbacks from the community labels Feb 3, 2023

IsaacMarovitz marked this pull request as ready for review February 6, 2023 05:27

TSRBerry marked this pull request as draft February 6, 2023 23:27

marysaka reviewed Feb 14, 2023

View reviewed changes

distribution/linux/mime/Ryujinx.xml Outdated Show resolved Hide resolved

distribution/macos/Info.plist Outdated Show resolved Hide resolved

marysaka mentioned this pull request Feb 22, 2023

nuget: bump XamlNameReferenceGenerator from 1.5.1 to 1.6.1 #4455

Closed

IsaacMarovitz force-pushed the ava-11 branch from 5e38773 to f86b8f0 Compare April 10, 2023 21:12

TSRBerry force-pushed the ava-11 branch from 7fbaf4e to 58a94e8 Compare April 29, 2023 00:04

IsaacMarovitz force-pushed the ava-11 branch 6 times, most recently from 9a61ce7 to ac04e7b Compare May 10, 2023 03:18

IsaacMarovitz force-pushed the ava-11 branch 2 times, most recently from 86499b0 to b62ca8a Compare May 16, 2023 14:53

IsaacMarovitz marked this pull request as ready for review May 16, 2023 14:58

Cleanup a bunch of jank

ecba830

IsaacMarovitz force-pushed the ava-11 branch from a78faeb to ecba830 Compare August 1, 2023 18:17

This was referenced Aug 1, 2023

Ava UI: Refactor async usage #5516

Merged

Ava UI: Remove all remaining uses of ReflectionBinding #5517

Closed

Merge branch 'master' into ava-11

b270f84

Dependency update

38cc7c7

IsaacMarovitz closed this Aug 10, 2023

IsaacMarovitz reopened this Aug 10, 2023

hez2010 reviewed Aug 11, 2023

View reviewed changes

src/Ryujinx.Ava/Ryujinx.Ava.csproj Show resolved Hide resolved

TSRBerry reviewed Aug 11, 2023

View reviewed changes

Berry fixes and suggestions

33d4593

IsaacMarovitz force-pushed the ava-11 branch from a6f8706 to 33d4593 Compare August 11, 2023 23:34

TSRBerry reviewed Aug 12, 2023

View reviewed changes

src/Ryujinx.Ava/AppHost.cs Outdated Show resolved Hide resolved

src/Ryujinx.Ava/AppHost.cs Outdated Show resolved Hide resolved

src/Ryujinx.Ava/Assets/Styles/Themes.xaml Outdated Show resolved Hide resolved

IsaacMarovitz and others added 2 commits August 12, 2023 01:22

Final suggestions

581f99f

Rename assemblyIdentity to Ryujinx.Emulator.Avalonia

d533659

TSRBerry approved these changes Aug 12, 2023

View reviewed changes

TSRBerry removed the needs-feedback The needs feedbacks from the community label Aug 12, 2023

TSRBerry merged commit 7b2225c into Ryujinx:master Aug 12, 2023
9 checks passed

IsaacMarovitz deleted the ava-11 branch August 12, 2023 13:55

Kurochi51 mentioned this pull request Sep 5, 2023

[Bug] Game crashes when clicking on a cheat name #5643

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ava UI: Avalonia 11 & FluentAvalonia 2 Support #4362

Ava UI: Avalonia 11 & FluentAvalonia 2 Support #4362

IsaacMarovitz commented Feb 3, 2023 •

edited

github-actions bot commented Feb 3, 2023 •

edited

marysaka commented Feb 3, 2023

TSRBerry commented Feb 6, 2023

IsaacMarovitz commented Feb 7, 2023

IsaacMarovitz commented May 16, 2023 •

edited

hez2010 commented Aug 2, 2023 •

edited

IsaacMarovitz commented Aug 2, 2023

GamerzHell9137 commented Aug 2, 2023 •

edited

hez2010 commented Aug 2, 2023

TSRBerry commented Aug 10, 2023

IsaacMarovitz commented Aug 10, 2023 •

edited

TSRBerry left a comment

TSRBerry left a comment

TSRBerry left a comment

Narugakuruga commented Aug 13, 2023

TSRBerry commented Aug 13, 2023

Ava UI: Avalonia 11 & FluentAvalonia 2 Support #4362

Ava UI: Avalonia 11 & FluentAvalonia 2 Support #4362

Conversation

IsaacMarovitz commented Feb 3, 2023 • edited

github-actions bot commented Feb 3, 2023 • edited

marysaka commented Feb 3, 2023

TSRBerry commented Feb 6, 2023

IsaacMarovitz commented Feb 7, 2023

IsaacMarovitz commented May 16, 2023 • edited

hez2010 commented Aug 2, 2023 • edited

IsaacMarovitz commented Aug 2, 2023

GamerzHell9137 commented Aug 2, 2023 • edited

hez2010 commented Aug 2, 2023

TSRBerry commented Aug 10, 2023

IsaacMarovitz commented Aug 10, 2023 • edited

RE - Game icons are sharper, Save Manager: Game icons look wrong and User profile manager: Firmware avatars look wrong

RE - User profile manager: Typo

RE - Settings window: User interface - too large for the window size

RE - File picker uses default window title and icon

RE - About window looks a little wrong now

RE - Toast notifications don't work anymore

TSRBerry left a comment

Choose a reason for hiding this comment

TSRBerry left a comment

Choose a reason for hiding this comment

TSRBerry left a comment

Choose a reason for hiding this comment

Narugakuruga commented Aug 13, 2023

TSRBerry commented Aug 13, 2023

IsaacMarovitz commented Feb 3, 2023 •

edited

github-actions bot commented Feb 3, 2023 •

edited

IsaacMarovitz commented May 16, 2023 •

edited

hez2010 commented Aug 2, 2023 •

edited

GamerzHell9137 commented Aug 2, 2023 •

edited

IsaacMarovitz commented Aug 10, 2023 •

edited

RE - `Game icons are sharper`, `Save Manager: Game icons look wrong` and `User profile manager: Firmware avatars look wrong`

RE - `User profile manager: Typo`

RE - `Settings window: User interface - too large for the window size`

RE - `File picker uses default window title and icon`

RE - `About window looks a little wrong now`

RE - `Toast notifications don't work anymore`