Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Vulkan requirements #4282

Merged
merged 4 commits into from Jan 26, 2023
Merged

Relax Vulkan requirements #4282

merged 4 commits into from Jan 26, 2023

Conversation

gdkchan
Copy link
Member

@gdkchan gdkchan commented Jan 13, 2023

Same as #4228, but now I also fixed MaxColorAttachmentIndex which was wrong and was breaking a lot of games. AttachmentIndices also had an additional index at the end for depth-stencil which was always 0. Due to that, if a depth-stencil texture was bound, MaxColorAttachmentIndex would be always 0. I have removed the useless 0 index at the end which should make the value of MaxColorAttachmentIndex correct, as it will be the index of the last color attachment as it should be.

I recommend actually testing it this time.

@gdkchan gdkchan added enhancement New feature or request gpu Related to Ryujinx.Graphics labels Jan 13, 2023
@gdkchan gdkchan requested a review from marysaka January 13, 2023 15:37
Ryujinx.Graphics.Vulkan/VulkanRenderer.cs Outdated Show resolved Hide resolved
@riperiperi
Copy link
Member

This seems to be breaking multithreaded compilation - the background compiled pipeline is different from the one requested by the first draw. Lots of logs like this:

00:00:09.033 |W| GUI.RenderLoop Gpu TryGetGraphicsPipeline: Background pipeline compile missed on draw - incorrect pipeline state?

Happens most notably in clubhouse games. The visuals across games seem fine.

@gdkchan
Copy link
Member Author

gdkchan commented Jan 23, 2023

This seems to be breaking multithreaded compilation - the background compiled pipeline is different from the one requested by the first draw. Lots of logs like this:

00:00:09.033 |W| GUI.RenderLoop Gpu TryGetGraphicsPipeline: Background pipeline compile missed on draw - incorrect pipeline state?

Happens most notably in clubhouse games. The visuals across games seem fine.

I fixed the ColorBlendAttachmentStateCount on PipelineConverter that was using a constant value before. It's the only thing I changed that could affect this I believe. Can you check if the issue is fixed?

I do still get Background pipeline compile missed on draw - incorrect pipeline state? warnings on some games still, but I also get them on master for at least a few months now, so it's hard to notice new warnings of this type caused by this change.

Copy link
Member

@riperiperi riperiperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, Pokemon Scarlet/Violet do seem to be triggering this on Master, will need to look into that at some point. The games I was getting this error on with this PR are fixed tho, and I'm not getting any other issues.

@gdkchan gdkchan merged commit 296c4a3 into Ryujinx:master Jan 26, 2023
@gdkchan gdkchan deleted the vk-pi branch January 26, 2023 21:34
@TonyMegaPro200
Copy link

hi, how could i download Ryujinx for Raspbian (Raspberry Pi 4) please

@gdkchan
Copy link
Member Author

gdkchan commented Apr 12, 2023

We are not releasing any Arm64 Linux build right now, you will have to build it yourself. Also it has been a few months, I don't know what is the current state of Ryujinx on the Raspberry Pi 4.

@TonyMegaPro200
Copy link

And do you know were can i find information for trying to build it on the raspberry pi?

@gdkchan
Copy link
Member Author

gdkchan commented Apr 12, 2023

It's the same process as building on any other platform. You can just follow the guide on the README (you need the Arm64 Linux SDK, not the x64 one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gpu Related to Ryujinx.Graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants