Implement copy dependency for depth and color textures

[gdkchan]

Luigi's Mansion 3 renders a texture using the R16Unorm format, and samples it using the D16Unorm format. We did not support that case before since those formats are not view compatible. This change adds support for this case using copies (copy dependency).

Fixes shadow issues on Luigi's Mansion 3.
Before:

RySd097vX5.mp4

After:

tmL7A8Gm9D.mp4

Thanks to @riperiperi for finding the issue.

Fixes #2791.

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+9c78bba-linux_x64
• ryujinx-Release-1.1.0+9c78bba-win_x64

Experimental GUI (Avalonia)

• ava-ryujinx-Release-1.1.0+9c78bba-linux_x64
• ava-ryujinx-Release-1.1.0+9c78bba-macos_universal
• ava-ryujinx-Release-1.1.0+9c78bba-win_x64

GUI-less (SDL2)

• sdl2-ryujinx-headless-Release-1.1.0+9c78bba-linux_x64
• sdl2-ryujinx-headless-Release-1.1.0+9c78bba-macos_universal
• sdl2-ryujinx-headless-Release-1.1.0+9c78bba-win_x64

Only for Developers

• ava-ryujinx-Debug-1.1.0+9c78bba-linux_x64
• ava-ryujinx-Debug-1.1.0+9c78bba-macos_universal
• ava-ryujinx-Debug-1.1.0+9c78bba-win_x64
• ryujinx-Debug-1.1.0+9c78bba-linux_x64
• ryujinx-Debug-1.1.0+9c78bba-win_x64
• sdl2-ryujinx-headless-Debug-1.1.0+9c78bba-linux_x64
• sdl2-ryujinx-headless-Debug-1.1.0+9c78bba-macos_universal
• sdl2-ryujinx-headless-Debug-1.1.0+9c78bba-win_x64

[gdkchan]

Now that the OpenGL regression was fixed and the other PR was merged, I was able to test it on OpenGL. Seems to be working correctly, so ready for review. It is using PBO copies on OpenGL which are usually slow, so I'm a bit worried about the performance there. But it's hard to tell since Luigi's Mansion 3 performance on OpenGL is already extremely poor here, at least without the mod to disable dynamic res that I don't have.

[Bjorn29512]

No noticeable regressions in botw, bayo 3 or smo with this PR, will update as i test more titles.

[riperiperi]

This PR causes BOTW to copy a depth texture back and forth every frame:

Normally:

It could definitely be a lot worse, but this could hurt weaker GPUs and might cause issues when scaling. I think the rules need to be changed to prefer the most recently modified texture instead of a "perfect" match. One weird case with that would be 2D copy to depth texture (as R32), I guess you'd still want the recently modified match as it will probably be D32 due to being used as a depth attachment.

[gdkchan]

I rebased it, but BOTW still copies between a R32Float and a D32Float texture on every frame. Not sure what was the plan to mitigate this, maybe keeping the FormatAlias compatibility and let it sample as the other format?

Update:
I also tried:

            if (lhsFormat.Format.IsDepthOrStencil() || rhsFormat.Format.IsDepthOrStencil())
            {
                bool forSampler = flags.HasFlag(TextureSearchFlags.ForSampler);
                bool depthAlias = flags.HasFlag(TextureSearchFlags.DepthAlias);

                TextureMatchQuality matchQuality = FormatMatches(lhs, rhs, forSampler, depthAlias);

                if (matchQuality == TextureMatchQuality.Perfect)
                {
                    return TextureViewCompatibility.Full;
                }
                else if (matchQuality == TextureMatchQuality.FormatAlias)
                {
                    return TextureViewCompatibility.FormatAlias;
                }
                else if (IsValidColorAsDepthAlias(lhsFormat.Format, rhsFormat.Format) || IsValidDepthAsColorAlias(lhsFormat.Format, rhsFormat.Format))
                {
                    return TextureViewCompatibility.CopyOnly;
                }
                else
                {
                    return TextureViewCompatibility.Incompatible;
                }
            }

(While keeping the FormatAlias compatibility) and the result was the same on BOTW, still doing copies every frame.

[riperiperi]

The texture lookup should prefer the last used texture when depth aliasing is possible. There's a possibility it selects the wrong one when the texture has a cached entry on the texture pool (it used it as R32 in the past, but the recent modifications were all D32)... But I'd imagine that should be random and happen after a while, not happen immediately. It might be necessary to remove pool entries in cases like this.

[gdkchan]

This should be ready for review again, #5719 stopped BOTW from copying depth textures every frame, so I think there's nothing blocking it now.

[marysaka]

lgtm

[Linear524]

Can't wait for this to merge into master branch :)

[riperiperi]

LGTM, tested on a few games and everything looks good. Nice work!

[Linear524]

Works like a charm !
Thanks @gdkchan and @riperiperi !
I've waited a loooooong for this fix :)