Update README.md

[lucicam]

Added note that the path should not contain spaces in order for the build to succeed. Seems like more people had this issue so it should at least be written in the readme. Related to #4428

[gdkchan]

Is having spaces really a problem when using dotnet build? I thought it was an issue with the macOS build script.

[siegmund-heiss-ich]

There is a problem at command execution codesign --entitlements <Path>.
(tested it on macOS)
I think it would be better to implement a solution for this directly in the code rather than telling the user how a working path should look like.

I think a path with backspaces would work if we had a backslash in front of every space.
We could check the path before command execution.

[EliEron]

Is having spaces really a problem when using dotnet build? I thought it was an issue with the macOS build script.

Building with spaces works fine on Windows & Linux, however while verifying this I did discover that there is one issue with the command in the readme. The -o option is no longer supported for building or publishing in the newest SDK (#15607) so that option should be removed from the readme.

[lucicam]

Actually, it's not the shell script which fails (at least not initially)

  Ryujinx.Ava -> /private/tmp/test build/Ryujinx/build/Ryujinx.Ava.dll
  /private/tmp/test: No such file or directory
/private/tmp/test build/Ryujinx/Ryujinx.Ava/Ryujinx.Ava.csproj(16,5): error MSB3073: The command "codesign --entitlements '/private/tmp/test build/Ryujinx/Ryujinx.Ava/../distribution/macos/entitlements.xml/' -f --deep -s - /private/tmp/test build/Ryujinx/build/Ryujinx.Ava" exited with code 1.

Build FAILED.

It fails because the command replaces the path but it contains spaces. I tried adding """ before and after the path, but doesn't seem to work

[lucicam]

Is having spaces really a problem when using dotnet build? I thought it was an issue with the macOS build script.

Building with spaces works fine on Windows & Linux, however while verifying this I did discover that there is one issue with the command in the readme. The -o option is no longer supported for building or publishing in the newest SDK (#15607) so that option should be removed from the readme.

This should be a problem in linux also, but probably it's not because there is no command which has spaces in the .csproj files

[lucicam]

I looked a bit into it and it seems to be some problem on linux/macos with msbuild, because I tried replacing the spaces with '\ ' (escaping the space) but it replaces it with '/ ' ... dotnet/msbuild#3468. I also tried to use with "%5C" instead of the backslash but it still replaces it with '/'.
I'm not too experienced with msbuild but it also seems like I can't really run shell scripts or command with pipe in them, so I'm not sure how we can fix this unless this issue is actually fixed on msbuild side.

[TimeZlicer]

<Exec Command="codesign --entitlements '$(ProjectDir)..\distribution\macos\entitlements.xml' -f --deep -s $(SigningCertificate) '$(TargetDir)$(TargetName)'" />

In Ryujinx.Ava.csproj, both paths need to be in single quote(')
This should resolve the error for dotnet build -c Release

---

create_app_bundle.sh
create_macos_release.sh
The paths in these scripts should be in double quote("), for example

dotnet publish -c Release -r osx-arm64 -o "$TEMP_DIRECTORY"/publish_arm64 $DOTNET_COMMON_ARGS Ryujinx.Ava  
dotnet publish -c Release -r osx-x64 -o "$TEMP_DIRECTORY"/publish_x64 $DOTNET_COMMON_ARGS Ryujinx.Ava

---

Hope the above helps

[lucicam]

Closed because @TimeZlicer made a PR fixing in multiple places. I can confirm it works with single quotes... I could have sworn I tried this exact thing but I probably put them in the wrong places -_-