macos: Add updater support #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marysaka
added
gui
This is a very basic updater but should be enough for now.
marysaka
force-pushed
the
feature/macos-updater
branch
from
48765d8
to
59ef0d3
Compare
|
Rebased |
gdkchan
reviewed
Feb 22, 2023
marysaka
force-pushed
the
feature/macos-updater
branch
from
12445bd
to
d865074
Compare
TSRBerry
reviewed
Feb 23, 2023
Co-authored-by: TSRBerry <20988865+TSRBerry@users.noreply.github.com>
gdkchan
reviewed
Feb 24, 2023
AcK77
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic updater but should be enough for now.
As we cannot replace ourself while running (otherwise we could get killed because our codesigning get invalidated), the update flow is a bit different. We use a bash script to replace the application and relaunch it.
I also did a bit of refactoring around to make InstallUpdate more readable.